Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new media type name #34752

Closed
wants to merge 2 commits into from
Closed

Add new media type name #34752

wants to merge 2 commits into from

Conversation

MichielDG
Copy link

I have added image/png because it is a common media type and don't know why it's not in there.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 9, 2020

Tagging @dotnet/ncl as an area owner

@dnfclas
Copy link

dnfclas commented Apr 9, 2020

CLA assistant check
All CLA requirements met.

@ManickaP
Copy link
Member

ManickaP commented Apr 9, 2020

@MichielDG is this PR based on any issue? If yes, could you link it please?

If not, then since this is a public type, we need to go through api review process. We should start with filing an issue tagged as an api-suggestion, then we can move on from that.

Could you file such an issue? For example look into this one, that's one I filed recently. If you need help, feel free to ping me, I'll gladly guide you through the process.

@ManickaP ManickaP added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 9, 2020
@MichielDG
Copy link
Author

MichielDG commented Apr 9, 2020

@ManickaP I've created an issue for this: #34758

@ManickaP
Copy link
Member

ManickaP commented Apr 9, 2020

Thanks, I'll bring it up in today's meeting so it can move forward.

@stephentoub
Copy link
Member

Thanks for the PR, @MichielDG. We generally welcome unsolicited PRs, but for new APIs in particular, we're more stringent and have a process we follow, outlined at https://github.com/dotnet/runtime/blob/master/docs/project/api-review-process.md; it requires approved APIs before PRs to implement them. There's an issue at #1489 tracking adding additional media types, and it's waiting for someone to propose the concrete set of additions; we'd welcome your help in fleshing that out with a concrete proposal. In the meantime, I'm going to close this. Thanks, again.

@stephentoub stephentoub closed this Apr 9, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants