Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete stale CPU cache size detection #34488

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Delete stale CPU cache size detection #34488

merged 2 commits into from
Apr 3, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 3, 2020

Fixes #34478

@jkotas jkotas requested a review from Maoni0 April 3, 2020 02:29
jkotas
jkotas commented Apr 3, 2020
View reviewed changes
src/coreclr/src/gc/gc.cpp Outdated Show resolved Hide resolved
@Maoni0
Copy link
Member

Maoni0 commented Apr 3, 2020

otherwise LGTM!

Maoni0
Maoni0 approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@jkotas jkotas merged commit fd60286 into dotnet:master Apr 3, 2020
@jkotas jkotas deleted the cachesizecleanup branch April 7, 2020 17:12
@mangod9 mangod9 mentioned this pull request Aug 28, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

Assignees
No one assigned
Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor GC performance on AMD processors (32-bit runtime)
3 participants
@jkotas @Maoni0 @Dotnet-GitSync-Bot