WIP: Shared library build #33608
Closed
WIP: Shared library build #33608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trylek
force-pushed
the
SharedLibraryBuild
branch
from
ab24c7b
to
e664c3f
Compare
jkotas
reviewed
Mar 15, 2020
| @@ -220,6 +223,8 @@ public sealed override bool TryGetModuleTokenForExternalType(TypeDesc type, out | |||
|
|
|||
| public sealed override bool IsCompositeBuildMode => _isCompositeBuildMode; | |||
|
|
|||
| public sealed override bool IsLibraryBuildMode => _isLibraryBuildMode; | |||
There was a problem hiding this comment.
Is the IsLibraryBuildMode flag used for anything? I am not able to find it.
There was a problem hiding this comment.
Hmm, the idea was that the library build mode can be used e.g. to tune rooting heuristics. You're right it's not wired up this way in this iteration; I can easily revert it if you don't think it's of any use.
There was a problem hiding this comment.
OK, for now I'm going to remove this as speculative code is generally not desirable and the current compilation logic doesn't actually need this.
There was a problem hiding this comment.
This can be easily added once it is actually needed. I do not think we should be adding this without the actual use.
trylek
force-pushed
the
SharedLibraryBuild
branch
3 times, most recently
from
d4cb9af
to
a8a1934
Compare
trylek
force-pushed
the
SharedLibraryBuild
branch
2 times, most recently
from
7b0e950
to
291aae8
Compare
trylek
force-pushed
the
SharedLibraryBuild
branch
3 times, most recently
from
18c3325
to
9db7fc0
Compare
This change adds SuperIlc support for the option --framework in --composite mode by first compiling the entire set of framework assemblies into one composite version bubble and then building the test on top of it as another composite version bubble. One practical upside of this mode is that it's naturally much faster than the "one-component" composite mode as that basically requires compiling the framework with each app. Thanks Tomas
This change adds SuperIlc support for the option --framework in --composite mode by first compiling the entire set of framework assemblies into one composite version bubble and then building the test on top of it as another composite version bubble. One practical upside of this mode is that it's naturally much faster than the "one-component" composite mode as that basically requires compiling the framework with each app. Thanks Tomas
trylek
force-pushed
the
SharedLibraryBuild
branch
from
9db7fc0
to
3b578f4
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds SuperIlc support for the option --framework
in --composite mode by first compiling the entire set of framework
assemblies into one composite version bubble and then building the
test on top of it as another composite version bubble. One practical
upside of this mode is that it's naturally much faster than the
"one-component" composite mode as that basically requires compiling
the framework with each app.
Thanks
Tomas