Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IBCMerge on OSX builds #33393

Merged

Conversation

jkoritzinsky
Copy link
Member

IBCMerge is crashing because of mismatched MVIDs on our OSX official builds. To unblock official builds, disable IBCMerge on our OSX builds.

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=552689&view=results

@jkoritzinsky jkoritzinsky added this to the 5.0 milestone Mar 9, 2020
@jkoritzinsky jkoritzinsky requested a review from a team March 9, 2020 18:42
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, deleted my comment I started typing about including a link to the issue :-). LGTM, thanks Jeremy!

@jkoritzinsky
Copy link
Member Author

@ViktorHofer have we updated to a new SDK with the NuGet fix? The CoreCLR Linux_musl Product Build leg hit that issue.

@ViktorHofer
Copy link
Member

@jkoritzinsky this hopefully fixes the issue for real: #33396.

@jkoritzinsky
Copy link
Member Author

Test failures are the NuGet issue and the "end of directory record" issue when downloading build artifacts.

@mmitche
Copy link
Member

mmitche commented Mar 9, 2020

This also needs to go into the preview2 branch. That build is also broken.

@jaredpar
Copy link
Member

jaredpar commented Mar 9, 2020

@mmitche see #33394

@jkoritzinsky
Copy link
Member Author

Tracking crossgen-comparison infra failure with #33404

@jkoritzinsky jkoritzinsky merged commit 31a65f0 into dotnet:master Mar 9, 2020
@jkoritzinsky jkoritzinsky deleted the fix-ibcmerge-failure-official-build branch March 9, 2020 22:37
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants