Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NativeCallableAttribute public. #33005

Merged
merged 53 commits into from
Mar 13, 2020
Merged

Make NativeCallableAttribute public. #33005

merged 53 commits into from
Mar 13, 2020

Commits on Mar 10, 2020

  1. Avoid creating a COM Delegate when calling NativeCallableWrapper.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7831946 View commit details
    Browse the repository at this point in the history

  2. Create fast P/Invoke frame. 

    Reduce indirection during typical PreStub operation (i.e. during COOP).
Verify reverse PInvoke transition is valid.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ddbfbeb View commit details
    Browse the repository at this point in the history

  3. Properly handle Preemptive thread in PreStubWorker.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2b0d128 View commit details
    Browse the repository at this point in the history

  4. Block fast NativeCallableAttribute on the X86 platform.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    669fb47 View commit details
    Browse the repository at this point in the history

  5. Limit the exclusion for fast NativeCallable to only Win-x86.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    3db83bf View commit details
    Browse the repository at this point in the history

  6. Add Reverse P/Invoke JIT helpers to CrossGen2.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ee166b2 View commit details
    Browse the repository at this point in the history

  7. Missing comma.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7a97eba View commit details
    Browse the repository at this point in the history

  8. Remove duplicate entries in ReadyToRunHelper enum.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    5b38870 View commit details
    Browse the repository at this point in the history

  9. Validate instantiated generic methods for ldftn.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    1dbc940 View commit details
    Browse the repository at this point in the history

  10. Add test cases for instantiated generic methods and call from unknown… 

    … native thread.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    391960f View commit details
    Browse the repository at this point in the history

  11. Disallow non-generic methods from a generic class to be NativeCallable

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ae3b190 View commit details
    Browse the repository at this point in the history

  12. Add test for generic class with NativeCallable static method.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    e42c27b View commit details
    Browse the repository at this point in the history

  13. Remove SAL annocations from NativeCallableAttribute test assets.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7fdc950 View commit details
    Browse the repository at this point in the history

  14. Move NativeCallableAttribute check to getCallInfo() in JIT interface.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    6e01d22 View commit details
    Browse the repository at this point in the history

  15. Add test for non static methods for NativeCallableAttribute

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    5525aeb View commit details
    Browse the repository at this point in the history

  16. [WIP] Check in CrossGen2 for NativeCallableAttribute usage.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2faea22 View commit details
    Browse the repository at this point in the history

  17. Publicly expose NativeCallableAttribute.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    028ef61 View commit details
    Browse the repository at this point in the history

  18. Add testing for exceptions on Windows.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4eba3e0 View commit details
    Browse the repository at this point in the history

  19. Add validation to CrossGen2.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    88a2548 View commit details
    Browse the repository at this point in the history

  20. Implement Unix EH change for NativeCallable methods

    @janvorli @AaronRobinsonMSFT
    janvorli authored and AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ff0a8f8 View commit details
    Browse the repository at this point in the history

  21. Update test.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    61e4a01 View commit details
    Browse the repository at this point in the history

  22. Update src/libraries/System.Private.CoreLib/src/System/Runtime/Intero… 

    …pServices/NativeCallableAttribute.cs

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
    @AaronRobinsonMSFT @jkotas
    AaronRobinsonMSFT and jkotas committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b1d6f1f View commit details
    Browse the repository at this point in the history

  23. Update src/libraries/System.Private.CoreLib/src/System/Runtime/Intero… 

    …pServices/NativeCallableAttribute.cs

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
    @AaronRobinsonMSFT @jkotas
    AaronRobinsonMSFT and jkotas committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    832f551 View commit details
    Browse the repository at this point in the history

  24. Error cases for NativeCallableAttribute should be InvalidProgramExcep… 

    …tion

  instead of NotSupportedException.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ba22026 View commit details
    Browse the repository at this point in the history

  25. Create ReadyToRun constant for Reverse PInvoke frame. 

    COMDelegate::ConvertToCallback is not only compiled on Win-x86 builds.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f0b71de View commit details
    Browse the repository at this point in the history

  26. Documentation update related to future C# language feature.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4f842f0 View commit details
    Browse the repository at this point in the history

  27. Revert "Implement Unix EH change for NativeCallable methods" 

    This reverts commit 2dbb74803f890ba5fbaf8158f1d98b5aa6776246.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f194c60 View commit details
    Browse the repository at this point in the history

  28. Implement Unix EH change for NativeCallable methods

    @janvorli @AaronRobinsonMSFT
    janvorli authored and AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f9acf93 View commit details
    Browse the repository at this point in the history

  29. Clean up tests

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    fefa431 View commit details
    Browse the repository at this point in the history

  30. Create a JIT_ReversePInvokeEnterRare() implementation for the slower … 

    …path

  during a reverse PInvoke enter.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    807f162 View commit details
    Browse the repository at this point in the history

  31. Move exception testing to Windows only since non-Windows will failfast.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b24d91c View commit details
    Browse the repository at this point in the history

  32. Mark rare path as NOINLINE.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    3a38cfd View commit details
    Browse the repository at this point in the history

  33. Add support to CallCountingManager for Preemptive threads.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    8d6b8c7 View commit details
    Browse the repository at this point in the history

  34. Revert "Add support to CallCountingManager for Preemptive threads." 

    This reverts commit 6e10c691cf537913d768d2b8f7ffebf3c0edb11f.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    edf0b61 View commit details
    Browse the repository at this point in the history

  35. Disable NativeCallableAttribute for TieredCompilation consideration.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    d8cb051 View commit details
    Browse the repository at this point in the history

  36. Handle the failure to create Thread in the reverse P/Invoke case.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    8567207 View commit details
    Browse the repository at this point in the history

  37. Use EEPOLICY_HANDLE_FATAL_ERROR_WITH_MESSAGE() for failfast.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    a2bff26 View commit details
    Browse the repository at this point in the history

  38. Revert "Disable NativeCallableAttribute for TieredCompilation conside… 

    …ration."

This reverts commit c0848abffcfe79cde78ed3402da03703c35c4195.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4369904 View commit details
    Browse the repository at this point in the history

  39. Disable Tiered Compilation for NativeCallableAttribute methods.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    c132966 View commit details
    Browse the repository at this point in the history

  40. Change name of new reverse P/Invoke frame to match CoreRT.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2f8b28b View commit details
    Browse the repository at this point in the history

  41. Manually inline enable preemptive.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    04cee50 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Handle issues for Tiered Compilation with NativeCallable in ReadyToRu… 

    …n images.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    c78f4a4 View commit details
    Browse the repository at this point in the history

  2. Add test for code path involving RuntimeHelpers.PrepareMethod().

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    898db75 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Handle additional locations for R2R scenarios.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 12, 2020
    2 Configuration menu
    Copy the full SHA
    105d53f View commit details
    Browse the repository at this point in the history

  2. Review feedback on crossgen.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    1091bfa View commit details
    Browse the repository at this point in the history

  3. Update CrossGen2 to match CrossGen semantics with respect to NativeCa… 

    …llable.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    6a3e11a View commit details
    Browse the repository at this point in the history

  4. Propagate the CallerGCMode in additional scenarios. 

    Create macro for fail fast create thread.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    cd421ac View commit details
    Browse the repository at this point in the history

  5. Feedback about local variable.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    2578835 View commit details
    Browse the repository at this point in the history

  6. Style fixes in CrossGen2

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    32981bc View commit details
    Browse the repository at this point in the history

  7. Update error message for FailFast during reverse P/Invoke.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    76442ce View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Change CrossGen2 exception type to NotImplementedException.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    1449088 View commit details
    Browse the repository at this point in the history

  2. Block R2R compilation of NativeCallableAttribute methods for crossgen… 

    ….exe.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    0a89a24 View commit details
    Browse the repository at this point in the history

  3. Throw RequiresRuntimeJitException instead of NotImplementedException … 

    …in Crossgen2.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    48758d4 View commit details
    Browse the repository at this point in the history