Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interlocked unsigned and bitwise operations #32216

Merged
merged 4 commits into from
Feb 14, 2020

Conversation

stephentoub
Copy link
Member

Fixes #24694
Fixes #23819

@GrabYourPitchforks, are the Xor methods really necessary? Where do you expect them to be used?

cc: @jkotas, @GrabYourPitchforks, @tannergooding

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@GrabYourPitchforks
Copy link
Member

are the Xor methods really necessary? Where do you expect them to be used?

I see some unmanaged usage with regard to job scheduling, but the scenarios for this (at least in C#) don't seem as clear-cut as the scenarios for And and Or. I'm not going to be terribly sad if we decide to nix Xor. It was really just for logical operator completeness.

@stephentoub
Copy link
Member Author

I'm not going to be terribly sad if we decide to nix xor

Ok, I'm going to remove it. I want to add things only when there's a strong demonstrated need, and I'm not seeing that for xor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants