Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new COM interop API for RCW/CCW creation/management #32091

Merged
merged 83 commits into from
Mar 7, 2020
Merged

Implement new COM interop API for RCW/CCW creation/management #32091

merged 83 commits into from
Mar 7, 2020

Commits on Mar 7, 2020

  1. Add API to SPCL.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    6dae493 View commit details
    Browse the repository at this point in the history

  2. Revert previous work.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    aa43ec8 View commit details
    Browse the repository at this point in the history

  3. Add API in stub form.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    e8846f1 View commit details
    Browse the repository at this point in the history

  4. Implement RuntimeHelpers.AllocateTypeAssociatedMemory()

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    7e0c328 View commit details
    Browse the repository at this point in the history

  5. Add tests for RuntimeHelpers.AllocateTypeAssociatedMemory

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    a1b0507 View commit details
    Browse the repository at this point in the history

  6. Update interop lib import/export API headers

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    39d5155 View commit details
    Browse the repository at this point in the history

  7. Implement the ComWrappers.GetIUnknownImpl() API

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    8e4e655 View commit details
    Browse the repository at this point in the history

  8. Add project for testing ComWrappers API. 

    Add test for the ComWrappers.GetIUnknownImpl() API.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1e88958 View commit details
    Browse the repository at this point in the history

  9. Stub out remaining ComWrapper QCall APIs

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    c375198 View commit details
    Browse the repository at this point in the history

  10. Add pseudo implementation and test for ComWrappers.RegisterForReferen… 

    …ceTrackerHost().
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    2b118c6 View commit details
    Browse the repository at this point in the history

  11. Add and validate metasigs for invoking static methods in ComWrappers … 

    …from within the runtime.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    705d02f View commit details
    Browse the repository at this point in the history

  12. Implement the runtime interation for managed object wrapper creation. 

    Update InteropSyncBlockInfo to hold onto wrapper instance.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    7ec6cc9 View commit details
    Browse the repository at this point in the history

  13. Write test for creation of managed object wrapper with tracker support.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    67949a7 View commit details
    Browse the repository at this point in the history

  14. Make managed object wrappers persistent until the associated managed … 

    …object is finalized.

Remove the CreateComInterfaceFlags.IgnoreCache
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    4ed9275 View commit details
    Browse the repository at this point in the history

  15. Update export namespaces in InteropLib

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    9249f51 View commit details
    Browse the repository at this point in the history

  16. Surround UNREACHABLE() with braces because of how it is defined.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    2a22388 View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary GCProtect sections. 

    Allocate External Object Context cache.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    33720f7 View commit details
    Browse the repository at this point in the history

  18. Retain the External Object Context in the SyncBlock and handle cleanup.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1a87a11 View commit details
    Browse the repository at this point in the history

  19. Rename ExtObjCxtIterator to RuntimeCallContext. 

    Add API for creating a Reference between an External Object and a MOW.
Update the existing RCWRefCache to work with the new InteropLib API.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    dbfa73f View commit details
    Browse the repository at this point in the history

  20. Change the CreateReference() API to an informing style API (i.e. Foun… 

    …dReferencePath).

  - This permits the runtime to make the decision on if the connection is meaningful.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1073eba View commit details
    Browse the repository at this point in the history

  21. Make global pegging field on RCWWalker public.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    0d80d43 View commit details
    Browse the repository at this point in the history

  22. Place all exported functions into a single compilation unit for Inter… 

    …opLib.

Add Begin/End reference tracking APIs.
Expose Global Pegging value to InteropLib.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    152a5e4 View commit details
    Browse the repository at this point in the history

  23. Add new API to make object release requests.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1bfb390 View commit details
    Browse the repository at this point in the history

  24. Address object release issues.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    3792204 View commit details
    Browse the repository at this point in the history

  25. Update public API

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    c83e6ec View commit details
    Browse the repository at this point in the history

  26. Add support for checking if an external object implements the 

      IReferenceTracker interface from the runtime side.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    d402fec View commit details
    Browse the repository at this point in the history

  27. Add comment about IEnumerable optimization.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    e508c34 View commit details
    Browse the repository at this point in the history

  28. Delay load ole32.dll to get RoGetAgileReference using GetProcAddress.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    46c357c View commit details
    Browse the repository at this point in the history

  29. TEST - WIP

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    0d3b9cf View commit details
    Browse the repository at this point in the history

  30. Reduce uses of GetReferenceTracker() - unsafe function. 

    Update CreateWrapperForExternal() to return a result struct with
  extra details.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    6e41699 View commit details
    Browse the repository at this point in the history

  31. Validation bug for converting to MOW.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    4a58326 View commit details
    Browse the repository at this point in the history

  32. Move the ComInterfaceEntry to the ABI namespace.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    f40127f View commit details
    Browse the repository at this point in the history

  33. Mock Tracker Runtime impl

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    a023e85 View commit details
    Browse the repository at this point in the history

  34. Forward declare Win32 API.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    942b19e View commit details
    Browse the repository at this point in the history

  35. Spelling mistake.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    76eae00 View commit details
    Browse the repository at this point in the history

  36. Move registration of global ComWrappers to be entirely in managed code.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    fa9af01 View commit details
    Browse the repository at this point in the history

  37. Remove unused message.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    c00ebd2 View commit details
    Browse the repository at this point in the history

  38. Add error message to managed resources. 

    Variable name feedback.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    4eb1240 View commit details
    Browse the repository at this point in the history

  39. Implement Peg/Unpeg

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    61dc744 View commit details
    Browse the repository at this point in the history

  40. Add additional testing.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    4d41a28 View commit details
    Browse the repository at this point in the history

  41. Test ignore cache logic.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    241e204 View commit details
    Browse the repository at this point in the history

  42. Change EnsureActiveWrapperAndAddRef() API to take an indirect OBJECTREF 

      and only create an OBJECTHANDLE if needed.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    aeb9403 View commit details
    Browse the repository at this point in the history

  43. Fix Release builds

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    362ea4b View commit details
    Browse the repository at this point in the history

  44. Apply review feedback about active wrapper API.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    4d4d395 View commit details
    Browse the repository at this point in the history

  45. Update src/coreclr/src/interop/comwrappers.h 

    Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
    @AaronRobinsonMSFT @jkotas
    AaronRobinsonMSFT and jkotas committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    5a9cbb4 View commit details
    Browse the repository at this point in the history

  46. Bug in ignore cache scenario - found during local GCStress run.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    48a1480 View commit details
    Browse the repository at this point in the history

  47. Finish off minimal testing scenarios.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    4bea8da View commit details
    Browse the repository at this point in the history

  48. Fix build issues on macOS using clang.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1bfea8c View commit details
    Browse the repository at this point in the history

  49. Update Windows' build in response to macOS build fixes.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1bb76c9 View commit details
    Browse the repository at this point in the history

  50. Release build fixes 

    Some CRST functions don't exist in Release builds.
Change usage of COMPlusThrow() to COMPlusThrowHR().
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    96ca3dc View commit details
    Browse the repository at this point in the history

  51. Remove ATL dependency from Mock Reference Tracker runtime library.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    c05b565 View commit details
    Browse the repository at this point in the history

  52. Always include ComHelper.h in COM tests.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    6e4fcce View commit details
    Browse the repository at this point in the history

  53. Add Release() impl on test ComSmartPtr<T>.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    2006fc6 View commit details
    Browse the repository at this point in the history

  54. Create a "support" and "nosupport" ComWrappers implementation.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    0041a35 View commit details
    Browse the repository at this point in the history

  55. Properly add a platform not supported implementation for ComWrappers.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    05c0035 View commit details
    Browse the repository at this point in the history

  56. Really remove the ComWrappers.NoSupport.cs file.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    8a69732 View commit details
    Browse the repository at this point in the history

  57. Forgot GetIUnknownImpl() API in the not supported version of ComWrapp… 

    …ers.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    e8d616c View commit details
    Browse the repository at this point in the history

  58. Remove InteropLib shutdown logic.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    b8703b1 View commit details
    Browse the repository at this point in the history

  59. Acquire RefCache at the same time as creating ObjectCache. This avoids 

      the need to handle a possible OOM at an inconvenient time.
Only define IsLockHeld() function in debug build.
Make usage of NULL consistent in interface cpp file.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    07cbc68 View commit details
    Browse the repository at this point in the history

  60. Add StressLogs to InteropLibInterface

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    c609b1c View commit details
    Browse the repository at this point in the history

  61. Cast OBJECTREFs so they work in StressLog macros.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    20a5385 View commit details
    Browse the repository at this point in the history

  62. Add a ComWrappers feature flag.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    8e97865 View commit details
    Browse the repository at this point in the history

  63. Remove duplicate entry.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    5fa679c View commit details
    Browse the repository at this point in the history

  64. Review feedback.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    e836507 View commit details
    Browse the repository at this point in the history

  65. Add Type? to the GetOrCreateObjectForComInstance() API call.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    e60bce2 View commit details
    Browse the repository at this point in the history

  66. Revert "Add Type? to the GetOrCreateObjectForComInstance() API call." 

    This reverts commit d0f6a5b04adbaa8e53445e4474780a9182ff8bde.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    75e8401 View commit details
    Browse the repository at this point in the history

  67. Update GetOrCreateObjectForComInstance() to accept 'object?' as the 

     defined wrapper. This will indicate to skip calling CallObject().
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    33194f9 View commit details
    Browse the repository at this point in the history

  68. Validate failure for reuse of wrapper for external object.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    7147244 View commit details
    Browse the repository at this point in the history

  69. Fix bug in failure case of attempting to reuse a wrapper.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1d87df4 View commit details
    Browse the repository at this point in the history

  70. Remove IAgileReference usage.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    17b5404 View commit details
    Browse the repository at this point in the history

  71. Apply API review comments.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    9cc5ccc View commit details
    Browse the repository at this point in the history

  72. Update test to align with API changes.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    1ae8587 View commit details
    Browse the repository at this point in the history

  73. Merge conflict.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    96fa8cc View commit details
    Browse the repository at this point in the history

  74. Review feedback.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    fc2f20a View commit details
    Browse the repository at this point in the history

  75. Add stub for AllocateTypeAssociatedMemory() in Mono build.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    9c4ecd5 View commit details
    Browse the repository at this point in the history

  76. Style and name.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    bc25078 View commit details
    Browse the repository at this point in the history

  77. Move RuntimeHelpers.AllocateTypeAssociatedMemory tests to src/libraries.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    d96ef4b View commit details
    Browse the repository at this point in the history

  78. Missed static

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    bfa455d View commit details
    Browse the repository at this point in the history

  79. Skip tests on Mono.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    b7c5c44 View commit details
    Browse the repository at this point in the history

  80. Unit test fix for RuntimeHelpers.AllocateTypeAssociatedMemory().

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    f305cb0 View commit details
    Browse the repository at this point in the history

  81. Bad merge on rebase.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    642ca9b View commit details
    Browse the repository at this point in the history

  82. Minor rewording for the interoplib interface.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    fa45add View commit details
    Browse the repository at this point in the history

  83. Feedback on naming.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    c7c6839 View commit details
    Browse the repository at this point in the history