Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete System.Data.SqlClient package #2275

Merged
merged 7 commits into from
Feb 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 0 additions & 6 deletions .config/CredScanSuppressions.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@
"/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs",
"/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs",
"/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionStringBuilderTest.cs",
"/src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/TdsEnums.cs",
"/src/libraries/System.Data.SqlClient/tests/FunctionalTests/DiagnosticTest.cs",
"/src/libraries/System.Data.SqlClient/tests/FunctionalTests/ExceptionTest.cs",
"/src/libraries/System.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs",
"/src/libraries/System.Data.SqlClient/tests/Tools/TDS/TDS.Servers/TDSServerArguments.cs",
"/src/libraries/System.Data.SqlClient/tests/Tools/TDS/TDS.Servers/TdsServerCertificate.pfx",
"/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs",
"/src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/constants.cs",
"/src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs",
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@
<RefOnlyMicrosoftBuildUtilitiesCoreVersion>$(RefOnlyMicrosoftBuildVersion)</RefOnlyMicrosoftBuildUtilitiesCoreVersion>
<RefOnlyNugetProjectModelVersion>4.9.4</RefOnlyNugetProjectModelVersion>
<RefOnlyNugetPackagingVersion>4.9.4</RefOnlyNugetPackagingVersion>
<!-- sni -->
<RuntimeWinX64RuntimeNativeSystemDataSqlClientSniVersion>4.4.0</RuntimeWinX64RuntimeNativeSystemDataSqlClientSniVersion>
<!-- System.Data.SqlClient -->
<SystemDataSqlClientVersion>4.8.0</SystemDataSqlClientVersion>
<!-- Testing -->
<MicrosoftNETTestSdkVersion>16.5.0</MicrosoftNETTestSdkVersion>
<XUnitVersion>2.4.1</XUnitVersion>
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tests/scripts/run-corefx-tests.bat
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ echo control, but is easy to implement. This file should be a list of assembly n
echo without filename extension, one per line, e.g.:
echo.
echo System.Console.Tests
echo System.Data.SqlClient.Tests
echo System.Data.Common.Tests
jkotas marked this conversation as resolved.
Show resolved Hide resolved
echo System.Diagnostics.Process.Tests
echo.
echo The ^<exclusion rsp file^> is in the form expected by xunit.console.dll as a response file.
Expand Down
23 changes: 0 additions & 23 deletions src/libraries/Native/pkg/Directory.Build.props

This file was deleted.

61 changes: 0 additions & 61 deletions src/libraries/Native/pkg/Directory.Build.targets

This file was deleted.

Empty file removed src/libraries/Native/pkg/_.pdb
Empty file.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
<Compile Include="System\Data\DeletedRowInaccessibleExceptionTest.cs" />
<Compile Include="System\Data\DuplicateNameExceptionTest.cs" />
<Compile Include="System\Data\EvaluateExceptionTest.cs" />
<Compile Include="System\Data\FacadeTest.cs" />
<Compile Include="System\Data\ForeignKeyConstraintTest.cs" />
<Compile Include="System\Data\ForeignKeyConstraintTest2.cs" />
<Compile Include="System\Data\InRowChangingEventExceptionTest.cs" />
Expand Down Expand Up @@ -119,4 +120,7 @@
<Link>Common\System\Runtime\Serialization\Formatters\BinaryFormatterHelpers.cs</Link>
</Compile>
</ItemGroup>
<ItemGroup>
<PackageReference Include="System.Data.SqlClient" Version="$(SystemDataSqlClientVersion)" />
</ItemGroup>
</Project>
19 changes: 19 additions & 0 deletions src/libraries/System.Data.Common/tests/System/Data/FacadeTest.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Licensed to the .NET Foundation under one or more agreements.
// See the LICENSE file in the project root for more information.

using Xunit;

namespace System.Data.Tests
{
public class FacadeTest
{
[Theory]
[InlineData("Microsoft.SqlServer.Server.SqlMetaData")] // Type from System.Data.SqlClient
[InlineData("System.Data.SqlTypes.SqlBytes")] // Type from System.Data.Common
public void TestSystemData(string typeName)
{
// Verify that the type can be loaded via .NET Framework compat facade
Type.GetType(typeName + ", System.Data", throwOnError: true);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using System.ComponentModel;
using System.Diagnostics;
using System.Globalization;
using System.Data.SqlClient;

namespace System.Data.Common
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
<ItemGroup Condition="'$(TargetsNetFx)' != 'true'">
<Reference Include="Microsoft.Win32.Registry" />
<Reference Include="System.Memory" />
<Reference Include="System.Data.SqlClient" />
<Reference Include="System.Configuration.ConfigurationManager" />
<Reference Include="System.Diagnostics.PerformanceCounter" />
<Reference Include="System.Security.Principal.Windows" />
Expand Down
6 changes: 0 additions & 6 deletions src/libraries/System.Data.SqlClient/Directory.Build.props

This file was deleted.

Loading