Improve performance of iterating with ForEach over ImmutableArray #1183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #780.
Use
AggressiveInline
onImmutableArray<T>.GetEnumerator
so the JIT can optimize theforeach
loops to be closer to the code when using an simpleT[]
.The benchmark for
String
doesn't show the same improvement because it is coded as a generic class, and the JIT can't apply the same optimization on a shared generic method called inside another shared generic class. But it's possible to see the same performance gain than theInt32
case in a non-generic benchmark.Based on the reported assembly from the benchmark, the code size doesn't increase even when inlining the method call, because the JIT is able to optimize the loop further and make it smaller (see the discussion on the issue for more details).
Benchmark results, including a non-generic version for comparison.
cc @adamsitnik, @danmosemsft, @AndyAyersMS