JIT: Clean up and optimize call arg lowering #112639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify the logic to be based purely off of new ABI info * Consistently insert bitcast nodes for register file mismatches when creating `PUTARG_REG` nodes and for `PUTARG_SPLIT` * Add a lowering optimization that removes `BITCAST` by changing the operand (by changing constants to other constants or the type of indirections)
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
jakobbotsch
commented
Feb 17, 2025
| #endif | ||
|
|
||
| return node; | ||
| return gtNewOperNode(GT_BITCAST, type, arg); |
There was a problem hiding this comment.
I missed simplifying this in #103869.
jakobbotsch
changed the title
EgorBo
reviewed
Feb 18, 2025
| // Returns: | ||
| // True if the bitcast was removed. | ||
| // | ||
| bool Lowering::TryRemoveBitCast(GenTreeUnOp* node) |
There was a problem hiding this comment.
Curious if we run this folding at the import stage as well
There was a problem hiding this comment.
I don't think so, we only have some folding for bitcasts in morph, and there we only have the IND/LCL_FLD part of this.
Only reason I ended up adding this is because I hit some regressions in this PR due to the new bitcasts.
EgorBo
reviewed
Feb 18, 2025
| // is not the case for NI_Vector128_AsVector128Unsafe which is explicitly taking | ||
| // a TYP_SIMD12 and producing a TYP_SIMD16. | ||
|
|
||
| type = TYP_SIMD12; |
EgorBo
approved these changes
Feb 18, 2025
jakobbotsch
commented
Feb 18, 2025
3 tasks
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 19, 2025
* main: (27 commits) Fold null checks against known non-null values (dotnet#109164) JIT: Always track the context for late devirt (dotnet#112396) JIT: array allocation fixes (dotnet#112676) [H/3] Fix test closing connection too fast (dotnet#112691) Fix LINQ handling of iterator.Take(...).Last(...) (dotnet#112680) [browser][MT] move wasm MT CI legs to extra-platforms (dotnet#112690) JIT: Don't use `Compiler::compFloatingPointUsed` to check if FP kills are needed (dotnet#112668) [LoongArch64] Fix a typo within PR#112166. (dotnet#112672) Fix new EH hang on DebugBreak (dotnet#112640) Use encode callback instead of renting a buffer to write to in DSAKeyFormatHelper Move some links to other doc (dotnet#112574) Reflection-based XmlSerializer - Deserialize empty collections and allow for sub-types in collection items. (dotnet#111723) JIT: Use `fgCalledCount` for OSR method entry weight (dotnet#112662) Use Avx10.2 Instructions in Floating Point Conversions (dotnet#111775) Expose StressLog via CDAC and port StressLogAnalyzer to managed code (dotnet#104999) JIT: Use linear block order for MinOpts in LSRA (dotnet#108147) Update dependencies from https://github.com/dotnet/arcade build 20250213.2 (dotnet#112625) JIT: Clean up and optimize call arg lowering (dotnet#112639) Update dependencies from https://github.com/dotnet/emsdk build 20250217.1 (dotnet#112645) JIT: Support `FIELD_LIST` for returns (dotnet#112308) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUTARG_REGnodes and forPUTARG_SPLITBITCASTby changing the operand (by changing constants to other constants or the type of indirections)