Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][ST] avoid thread interruption checkpoint #112637

Closed
wants to merge 2 commits into from
Closed

[browser][ST] avoid thread interruption checkpoint #112637

wants to merge 2 commits into from

Conversation

pavelsavara
Copy link
Member

This should make AOT smaller and everything faster in ST.

  • rename mono_opt_wasm_gc_safepoints to mono_opt_wasm_disable_threads and negate it
  • mono_marshal_shared_emit_thread_interrupt_checkpoint_call and emit_thread_interrupt_checkpoint used only then threads are not disabled
  • avoid mono_thread_interruption_checkpoint in ST monitor.c
  • ifdef threads.c
  • empty EXCEPTION_CHECKPOINT for ST

Fixes #112631

@pavelsavara
- rename mono_opt_wasm_gc_safepoints to mono_opt_wasm_disable_threads…
18e6755 
… and negate it

- mono_marshal_shared_emit_thread_interrupt_checkpoint_call only then threads are not disabled
- avoid mono_thread_interruption_checkpoint in ST monitor.c
- annotate threads.c
- empty EXCEPTION_CHECKPOINT for ST
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Feb 17, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Feb 17, 2025
@pavelsavara pavelsavara self-assigned this Feb 17, 2025
This was referenced Feb 17, 2025
Open
Open
Open
@pavelsavara pavelsavara mentioned this pull request Feb 18, 2025
Open
@pavelsavara
Copy link
Member Author

cc @BrzVlad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf Awaiting requested review from maraf maraf will be requested when the pull request is marked ready for review maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger will be requested when the pull request is marked ready for review akoeplinger is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad will be requested when the pull request is marked ready for review BrzVlad is a code owner

@kotlarmilos kotlarmilos Awaiting requested review from kotlarmilos kotlarmilos will be requested when the pull request is marked ready for review kotlarmilos is a code owner

@lateralusX lateralusX Awaiting requested review from lateralusX lateralusX will be requested when the pull request is marked ready for review lateralusX is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg will be requested when the pull request is marked ready for review thaystg is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[Mono] mono_thread_interruption_checkpoint
1 participant
@pavelsavara