Remove incompatible API from PKCS netstandard2.0 lib #112591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package used to contain a reference assembly that did not describe these members. When the reference assemblies were removed from the package, these members became visible; but they aren't present on .NET Framework, so a netstandard 2.0 build that runs on .NET Framework gets a lot of missing member exceptions.
bartonjs
added
area-System.Security
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/libraries/System.Security.Cryptography.Pkcs/src/CompatibilitySuppressions.xml: Language not supported
- src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/SignedCms.cs: Evaluated as low risk
- src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampRequest.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/EnvelopedCms.cs:232
- Ensure that the Decrypt method's behavior is covered by tests, especially with the conditional compilation changes.
void Decrypt(RecipientInfo recipientInfo, AsymmetricAlgorithm? privateKey)
This was referenced Feb 15, 2025
Open
This was referenced Feb 16, 2025
vcsjones
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package used to contain a reference assembly that did not describe these members. When the reference assemblies were removed from the package, these members became visible; but they aren't present on .NET Framework, so a netstandard 2.0 build that runs on .NET Framework gets a lot of missing member exceptions.
Fixes #111749