Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test IUnknown conforming #112566

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

AaronRobinsonMSFT
Copy link
Member

The test was written quickly to validate basic interface marshalling. It was implemented on the stack to try and avoid fully implementing ref counting. This is an issue because of RCW clean-up, which can happen long after the native caller has returned.

Introduced in #112375
Fixes #112545

@AaronRobinsonMSFT AaronRobinsonMSFT added test-bug Problem in test source code (most likely) area-Interop-coreclr labels Feb 14, 2025
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Feb 14, 2025
@Copilot Copilot bot review requested due to automatic review settings February 14, 2025 15:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/tests/Interop/COM/NativeClients/MiscTypes/MiscTypes.cpp: Language not supported
@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Make test IUnknown conforming Make test IUnknown conforming Feb 14, 2025
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 10532bf into dotnet:main Feb 14, 2025
81 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_112545 branch February 14, 2025 20:07
grendello added a commit to grendello/runtime that referenced this pull request Feb 18, 2025
* main: (71 commits)
  Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250212.3 (dotnet#112626)
  JIT: Unify struct arg morphing (dotnet#112612)
  Enable `SA1015`: Closing generic bracket should not be followed by a space (dotnet#112597)
  Clean up normalizeLocale for mono browser target (dotnet#112575)
  SPMI: Ensure proper zero extension for isObjectImmutable and friends (dotnet#112617)
  Quote --version-scripts path (dotnet#112603)
  Remove incompatible API from PKCS netstandard2.0 lib
  [main] Update dependencies from dotnet/emsdk (dotnet#112393)
  Avoid `Unsafe.As` in `RangeCharSearchValues` (dotnet#112606)
  Fixed the issue of incorrect return value of PalVirtualAlloc (dotnet#112579)
  Fix size used for vectorization check in BitArray (dotnet#111558) (dotnet#111564)
  Fix build of windows arm64 crossdac (dotnet#112553)
  Simplify `ShuffleTakeIterator.GetCount` (dotnet#112593)
  Fix VS div-by-0 in DacEnumerableHashTable code (dotnet#112542)
  R2RDump: normalize GC info totalInterruptibleLength (dotnet#112003)
  Fix alignment padding and add test for saving managed resources (dotnet#110915)
  Adds `ccmp` logic into emitter backend. (dotnet#112153)
  Disable AVX10.2 by default (dotnet#112572)
  Outbox AesGcm in to Microsoft.Bcl.Cryptography
  Make test `IUnknown` conforming (dotnet#112566)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Interop-coreclr test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Interop/COM/NativeClients/MiscTypes/MiscTypes.cmd
3 participants