-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to NuGet package pruning warnings #112357
base: main
Are you sure you want to change the base?
Conversation
Contributes to dotnet/sdk#46642 NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted. Resolve the few warnings that got emitted in ref projects when source-building the repository.
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
</ItemGroup> | ||
</Target> | ||
|
||
<Target Name="WarnOnProjectReferenceToFrameworkAssemblies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check that NuGet is getting the right data for pruning when we use our live-built framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I just added a commit that generates the PackageOverrides.txt file as part of the libs.sfx
subset.
There could be few more in different build subsets:
|
There are definitely more. This is for the number of projects that get source-built. I will submit another set of PRs to repos when we update Arcade or the VMR to an SDK that has package pruning enabled. |
Contributes to dotnet/sdk#46642
NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.
Resolve the few warnings that got emitted in ref projects when source-building the repository.
Also delete the target in packaging.targets as NuGet now handles this for us instead.