-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CryptoConfigForwarder
et al.
#112306
base: main
Are you sure you want to change the base?
Conversation
This class does not seem to be necessary after the unification of the crypto assemblies.
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/libraries/System.Security.Cryptography/src/System.Security.Cryptography.csproj: Language not supported
- src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptoConfig.Common.cs: Evaluated as low risk
- src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptoConfigForwarder.cs: Evaluated as low risk
- src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/KeyedHashAlgorithm.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptoConfig.cs:16
- [nitpick] The error message string 'CreateFromNameUnreferencedCodeMessage' could be clearer. Consider rephrasing to 'The default algorithm implementations might be removed. Use strong type references like 'RSA.Create()' instead.'
internal const string CreateFromNameUnreferencedCodeMessage = "The default algorithm implementations might be removed, use strong type references like 'RSA.Create()' instead.";
This class does not seem to be necessary after the unification of the crypto assemblies. I also fixed a typo and did some minor clean-up.