Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CertFreeCRLContext #112207

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 5, 2025

Move CertFreeCRLContext to Interop/Windows/Crypt32/Interop.CertFreeCRLContext.cs.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 5, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 5, 2025
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 6, 2025

@joperezr I wonder why we call CertFreeCRLContext instead of CertFreeCertificateContext.

try
{
Debug.Assert(serverCert != IntPtr.Zero);
certPtr = Marshal.ReadIntPtr(serverCert);
certificate = new X509Certificate(certPtr);
}
finally
{
PALCertFreeCRLContext(certPtr);
}

@xtqqczze xtqqczze marked this pull request as draft February 6, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant