New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DateOnly, TimeOnly, ISOWeek #111244

Merged

tarekgh merged 2 commits into dotnet:main from pentp:time-lean

Jan 14, 2025

Contributor

pentp commented Jan 9, 2025

Small optimizations and cleanup.


          Optimize DateOnly, TimeOnly, ISOWeek

56488e0

dotnet-issue-labeler bot added the area-System.DateTime label

dotnet-policy-service bot added the community-contribution label

Contributor

dotnet-policy-service bot commented Jan 9, 2025

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

tarekgh reviewed

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/DateTime.cs Outdated Show resolved Hide resolved

tarekgh reviewed

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/TimeOnly.cs Outdated Show resolved Hide resolved

tarekgh reviewed

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/TimeOnly.cs Outdated Show resolved Hide resolved

tarekgh reviewed

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/TimeOnly.cs Show resolved Hide resolved

tarekgh reviewed

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormat.cs Show resolved Hide resolved

Member

tarekgh commented Jan 9, 2025

Any benchmark numbers for the optimized parts?

tarekgh added this to the 10.0.0 milestone

This was referenced Jan 9, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

System.Net.Quic.Tests.MsQuicTests.WriteTests failed with "System.Net.Quic.QuicException : The connection timed out from inactivity." #105177

Open

ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756

Open

Contributor

xtqqczze commented Jan 9, 2025

Maybe rename the method UnsafeCreate to CreateUnchecked as part of these changes, since the method does not involve the use of unsafe context or types like Unsafe.

Member

tarekgh commented Jan 13, 2025

@pentp did you have a chance to address the remaining feedback so we can proceed completing this PR?


          Address PR feedback

e155c38

tarekgh approved these changes

View reviewed changes

Member

tarekgh left a comment

Thanks @pentp!

Member

tarekgh commented Jan 14, 2025

/ba-g failure is a build timeout which is observed on other PRs too.

tarekgh merged commit e5ed253 into dotnet:main

134 of 139 checks passed

This was referenced Jan 14, 2025

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879

Open

[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090

Open

pentp deleted the time-lean branch

January 14, 2025 14:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.DateTime community-contribution