Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestOnly][release/9.0-staging] Fix TimeProvider Test #111132

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 6, 2025

Fixes #107571

Backport of #111080 to release/9.0-staging

/cc @tarekgh

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 6, 2025
@tarekgh tarekgh changed the title [release/9.0-staging] Fix TimeProvider Test [TestOnly][release/9.0-staging] Fix TimeProvider Test Jan 6, 2025
@tarekgh tarekgh added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 6, 2025
@tarekgh tarekgh added this to the 9.0.x milestone Jan 6, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

@ericstj ericstj added the Servicing-approved Approved for servicing release label Jan 6, 2025
@ericstj
Copy link
Member

ericstj commented Jan 6, 2025

Marking test-only change as servicing-approved.

@ericstj ericstj merged commit bbd7132 into release/9.0-staging Jan 6, 2025
84 of 89 checks passed
@jkotas jkotas deleted the backport/pr-111080-to-release/9.0-staging branch January 8, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.DateTime Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants