Support writing base64 JSON segments #111041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
1 similar comment
|
Note regarding the |
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
This was referenced Jan 3, 2025
Open
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.cs
Outdated
Show resolved
Hide resolved
...ies/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.StringSegment.cs
Outdated
Show resolved
Hide resolved
...ies/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.StringSegment.cs
Show resolved
Hide resolved
...es/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.Values.StringSegment.cs
Outdated
Show resolved
Hide resolved
...es/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.Values.StringSegment.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /// <summary> | ||
| /// The partial UTF-8 code point. | ||
| /// </summary> | ||
| private ReadOnlySpan<byte> PartialUtf8CodePoint | ||
| private ReadOnlySpan<byte> PartialUtf8StringData | ||
| { | ||
| get | ||
| { | ||
| Debug.Assert(PreviousSegmentEncoding == SegmentEncoding.Utf8); |
There was a problem hiding this comment.
I'm guessing PreviousSegmentEncoding would eventually be replaced by "enclosing container" data as introduced in #111332
There was a problem hiding this comment.
That PR doesn't do it but it could in order to avoid the bit twiddling that PreviousSegmentEncoding currently does.
eiriktsarpalis
approved these changes
Jan 14, 2025
|
/ba-g There are known infrastructure errors and test errors. The other build failure was an unrelated timeout affecting other PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to the Utf8JsonWriter for writing string value segments of
byte[]encoded as Base64 UTF-8.Closes #67337