-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[S390x] Fix endian bug in minipal #110985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Dec 29, 2024
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Dec 29, 2024
cc: @jkoritzinsky |
3 tasks
jkoritzinsky
approved these changes
Dec 30, 2024
can this be merged? |
saitama951
added a commit
to saitama951/dotnet-s390x
that referenced
this pull request
Jan 2, 2025
backport fixes dotnet/runtime#110985 dotnet/runtime#107559 add mandatory dependency in DockerFile dotnet/runtime#109681 dotnet/arcade#15233
saitama951
added a commit
to saitama951/dotnet-s390x
that referenced
this pull request
Jan 2, 2025
backport fixes dotnet/runtime#110985 dotnet/runtime#107559 add mandatory dependency in DockerFile dotnet/runtime#109681 dotnet/arcade#15233 Signed-off-by: Sanjam Panda <sanjam.panda@ibm.com>
iii-i
pushed a commit
to IBM/dotnet-s390x
that referenced
this pull request
Jan 2, 2025
backport fixes dotnet/runtime#110985 dotnet/runtime#107559 add mandatory dependency in DockerFile dotnet/runtime#109681 dotnet/arcade#15233 Signed-off-by: Sanjam Panda <sanjam.panda@ibm.com>
saitama951
added a commit
to saitama951/dotnet-s390x
that referenced
this pull request
Jan 6, 2025
backport fixes dotnet/runtime#110985 dotnet/runtime#107559 add mandatory dependency in DockerFile dotnet/runtime#109681 dotnet/arcade#15233 Signed-off-by: Sanjam Panda <sanjam.panda@ibm.com>
saitama951
added a commit
to saitama951/dotnet-s390x
that referenced
this pull request
Jan 9, 2025
backport fixes dotnet/runtime#110985 dotnet/runtime#107559 add mandatory dependency in DockerFile dotnet/runtime#109681 dotnet/arcade#15233 Signed-off-by: Sanjam Panda <sanjam.panda@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
Indicates that the PR has been added by a community member
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #107889 is merged we see test cases crashing on s390x
This is primarily because the "BIGENDIAN" macro is defined in
src/native/minipal/minipalconfig.h.in
which generates aminipalconfig.h
which needs to be included inutf8.c
in order for the macro to be used there.