-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] fix browser-wasm debug build #110943
base: release/9.0
Are you sure you want to change the base?
Conversation
This PR adds the profiler-log component into default build (which people ship when they don't use wasm workload). I'm not sure we want to merge this. @srxqds what's your intention here ? |
Tagging subscribers to 'arch-wasm': @lewing |
we build debug local, it will hit undefined symbol I found the main branch have fixed from this pr #108185 |
Thank you for explanation. @lewing do you think this meets servicing bar ? cc @maraf |
I think it is ok for what is effectively an infra fix for the debug build |
@pavelsavara @lewing friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month. |
Backport of #108185