JIT: remove phis right after optimizing #110821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They serve no useful purpose once SSA is gone, and they potentially confuse other parts of the JIT. Was also going to make the PHIs zero cost, but this apparently was already done (not sure when/how). Closes dotnet#88841
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@jakobbotsch PTAL Unblocks a few if-conversion opportunities. Many fewer diffs then when I originally tried this. |
jakobbotsch
approved these changes
Dec 18, 2024
MichalStrehovsky
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit 43f7d32.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They serve no useful purpose once SSA is gone, and they potentially confuse other parts of the JIT.
Was also going to make the PHIs zero cost, but this apparently was already done (not sure when/how).
Closes #88841