Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TagName docs to include behavior if tag is not found #109934

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Update TagName docs to include behavior if tag is not found #109934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c97e22
Clarify documentation for TagList.IndexOf
mpdelbuono Nov 18, 2024
f5d1862
Clarify documentation for TagList.IndexOf
mpdelbuono Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/TagList.netcore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ public bool Remove(KeyValuePair<string, object?> item)
/// Searches for the specified tag and returns the zero-based index of the first occurrence within the entire <see cref="T:System.Diagnostics.TagList" />.
/// </summary>
/// <param name="item">The tag to locate in the <see cref="T:System.Diagnostics.TagList" />.</param>
/// <returns>The zero-based index of the first occurrence within the <see cref="T:System.Diagnostics.TagList" />, or -1 if there is no such tag.</returns>
public readonly int IndexOf(KeyValuePair<string, object?> item)
{
ReadOnlySpan<KeyValuePair<string, object?>> tags =
Expand Down
1 change: 1 addition & 0 deletions ...aries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/TagList.netfx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ public bool Remove(KeyValuePair<string, object?> item)
/// Searches for the specified tag and returns the zero-based index of the first occurrence within the entire <see cref="T:System.Diagnostics.TagList" />.
/// </summary>
/// <param name="item">The tag to locate in the <see cref="T:System.Diagnostics.TagList" />.</param>
/// <returns>The zero-based index of the first occurrence within the <see cref="T:System.Diagnostics.TagList" />, or -1 if there is no such tag.</returns>
public readonly int IndexOf(KeyValuePair<string, object?> item)
{
if (_overflowTags is not null)
Expand Down
Loading