Skip to content

[release/9.0] [cdac][cdac-build-tool] Don't let msbuild rewrite the resource name #108296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2024
Merged

[release/9.0] [cdac][cdac-build-tool] Don't let msbuild rewrite the resource name #108296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
494d7a6
[cdac][cdac-build-tool] Don't let msbuild rewrite the resource name
lambdageek Sep 26, 2024
8db5d6b
Merge branch 'release/9.0' into backport/pr-108289-to-release/9.0
jeffschwMSFT Oct 2, 2024
b6c0f7b
Merge branch 'release/9.0' into backport/pr-108289-to-release/9.0
jeffschwMSFT Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreclr/tools/cdac-build-tool/cdac-build-tool.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
<BaselineManifestResourcePrefix>Microsoft.DotNet.Diagnostics.DataContract.Baseline:</BaselineManifestResourcePrefix>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="Resources/contract-descriptor.c.in" />
<EmbeddedResource Include="Resources/contract-descriptor.c.in" WithCulture="false" />
<!-- embed baseline specs with manifest resource names like Microsoft.DotNet.Diagnostics.DataContract.Baseline:net9.0/osx-arm64.jsonc -->
<!-- TODO: [cdac] - make sure we use / not \ on windows, too. -->
<EmbeddedResource Include="$(RepoRoot)docs\design\datacontracts\data\**\*.jsonc" LogicalName="$(BaselineManifestResourcePrefix)%(RecursiveDir)%(Filename)%(Extension)" />
<EmbeddedResource Include="$(RepoRoot)docs\design\datacontracts\data\**\*.jsonc" LogicalName="$(BaselineManifestResourcePrefix)%(RecursiveDir)%(Filename)%(Extension)" WithCulture="false" />
</ItemGroup>
</Project>
Loading