Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2603456 #107711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Build ID 2536282
… Build ID 2536282
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
|
@carlossanlop -- should this target release/9.0? |
ericstj
requested review from
marek-safar,
sbomer,
akoeplinger,
maraf,
ilonatommy,
lewing,
pavelsavara,
janvorli,
AaronRobinsonMSFT,
a team,
lambdageek,
steveisok,
kg,
BrzVlad,
kotlarmilos,
fanyang-mono and
thaystg
as code owners
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
… Build ID 2594242
… Build ID 2594241
dotnet-bot
changed the title
dotnet-bot
changed the title
… Build ID 2594450
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
… Build ID 2596490
… Build ID 2596490
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
For some reason the loc insertion was putting a space in this identifier, which breaks the build. Undo that change for now, issue is tracked in https://ceapex.visualstudio.com/CEINTL/_workitems/create/Feedback?templateId=532ad3a8-b25f-4217-a028-979ac4c34340&ownerId=354effea-8ab7-482a-946d-358eae314712
ericstj
reviewed
Dec 17, 2024
| <trans-unit id="RegexMemberMustHaveValidSignatureMessage"> | ||
| <source>GeneratedRegexAttribute method or property must be partial, parameterless, non-generic, non-abstract, and return Regex. If a property, it must also be get-only.</source> | ||
| <target state="new">GeneratedRegexAttribute method or property must be partial, parameterless, non-generic, non-abstract, and return Regex. If a property, it must also be get-only.</target> | ||
| <trans-unit id="RegexMethodMustHaveValidSignatureMessage"> |
There was a problem hiding this comment.
This also seems to be undoing a change from June. 2bf492b#diff-4b415858dc6fa5baaeb017f57860b16e6f0e2479dd6092133aaeeb7765eb9c7bR195
There was a problem hiding this comment.
this is expected as far as I understand the loc system since the id changed.
ericstj
reviewed
Dec 17, 2024
| @@ -142,16 +142,6 @@ | |||
| <target state="translated">Typ obsahuje více členů s komentářem JsonExtensionDataAttribute</target> | |||
| <note /> | |||
| </trans-unit> | |||
| <trans-unit id="TypeContainsRefLikeMemberFormat"> | |||
There was a problem hiding this comment.
This is undoing a change made in August c1ab6c5#diff-41f0a49909511e29afd9f8ee632594843d510f106249d7cede193017500dba57R145
ericstj
reviewed
Dec 17, 2024
| @@ -132,16 +132,6 @@ | |||
| <target state="translated">Našlo se několik polí typu Microsoft.Extensions.Logging.ILogger</target> | |||
| <note>{Locked="Microsoft.Extensions.Logging.ILogger"}</note> | |||
| </trans-unit> | |||
| <trans-unit id="PrimaryConstructorParameterLoggerHiddenMessage"> | |||
There was a problem hiding this comment.
This is undoing a change from May.
9daa4b4#diff-2b526fe79ad2825b0cb16698c883ce0f55f5c11973e0a4a745c4c987d1a9b515R135
ericstj
reviewed
Dec 17, 2024
| @@ -67,16 +67,6 @@ | |||
| <target state="translated">Die Basis-COM-Schnittstelle konnte die Quelle nicht generieren. Für diese Schnittstelle wird kein Code generiert.</target> | |||
| <note /> | |||
| </trans-unit> | |||
| <trans-unit id="BaseInterfaceDefinedInOtherAssemblyMessage"> | |||
There was a problem hiding this comment.
More removals from changes in the last year: 1563fec#diff-460bca8455e8cb028783e1b1e3f1b9829b0c6a5a2912ee8a6b130786a42696ad
|
I wonder if the problem is caused by us using release/9.0 for the OneLoc job in main? We have #95024 to revert that. /cc @carlossanlop |
|
We haven't switched back to main since we had all the oneloc changes merged and shipped in release/9.0, so this PR is very stale. I opened #111872 to fix this and we will have to wait for a new OneLoc PR to come in, so I'll close this. |
carlossanlop
deleted the
locfiles/a976360c-7f4f-47e7-b5f1-7757b1294155
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.