-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Run new block layout only in backend #107634
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Churn is quite big, and varies between platforms. This churn seems to be driven by LSRA visiting blocks in a different order. Would it make sense to instead visit blocks in RPO to make it layout-agnostic? cc @kunalspathak |
Now that LSRA is using its own block order, the diffs seem to be contained to methods with switch statements. I see two broad sources of diffs:
I think modernizing switch lowering is a worthy goal, though since we already don't place as much emphasis on layout quality for switch blocks, I think we should take this churn for now to expedite enabling 3-opt. @AndyAyersMS are you ok with this? |
Yes |
SPMI failure is a timeout, and libraries test failure is known. |
Follow-up to #107483. This had a lot of churn in both directions locally, though layout doesn't seem to have changed.