[release/9.0] Fix heap corruption issue in PriorityQueue.Remove #107603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-collections |
eiriktsarpalis
requested review from
jeffhandley,
carlossanlop and
stephentoub
eiriktsarpalis
added
the
Servicing-consider
|
@eiriktsarpalis - when did this first manifest in the product? |
With the introduction of the impacted method -- #93994 |
artl93
approved these changes
Sep 10, 2024
artl93
added
Servicing-approved
stephentoub
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107550 to release/9.0
/cc @eiriktsarpalis
Customer Impact
The newly added
PriorityQueue.Removemethod has bug which under certain circumstances can result in heap invariants not being preserved. In practice this means that elements can be dequeued out-of-order violating the guarantees of the collection.Regression
Testing
Added unit testing validating correctness for inputs where the issue is manifested.
Risk
Low. Makes a targeted change in production code adding an omitted order comparison.