Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] Upgrade zlib-ng to 2.2.1 #107404

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

carlossanlop
Copy link
Member

Backport of #105771 to release/9.0

/cc @carlossanlop @jkotas

Customer Impact

  • Customer reported
  • Found internally

Changes in this PR:

  • Update the native vendored version of zlib-ng to the latest release 2.2.1, released on July 2nd.
  • Applies a patch that has already been sent upstream to fix some cmake errors due to missing explicit castings and asserts.
  • Removes the custom allocator we were using. It's no longer needed.
  • Also updates some tests that were comparing the file sizes for compression ratios that are too close to each other, which are cases where it cannot be guaranteed that the expected file size differences will always be seen.
  • Updated the licensing files.

Regression

  • Yes
  • No

Testing

CI results succeeded.

Risk

Low.

@carlossanlop carlossanlop added Servicing-consider Issue for next servicing release review area-Infrastructure labels Sep 5, 2024
@carlossanlop carlossanlop added this to the 9.0.0 milestone Sep 5, 2024
@carlossanlop carlossanlop self-assigned this Sep 5, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@artl93 artl93 added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 5, 2024
@carlossanlop carlossanlop merged commit 7ec9980 into dotnet:release/9.0 Sep 5, 2024
163 of 167 checks passed
@carlossanlop carlossanlop deleted the UpgradeZlibNg9 branch September 5, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants