Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Update dependencies from dotnet/roslyn #106924

Merged
merged 12 commits into from
Sep 6, 2024
Merged

[release/9.0] Update dependencies from dotnet/roslyn #106924

merged 12 commits into from
Sep 6, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 24, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 4e935e41-2044-4302-dc03-08dcbc3acc3c
  • Build: 20240906.1
  • Date Produced: September 6, 2024 9:22:32 AM UTC
  • Commit: 1ce264cab372119376a734a247e9f60fe898877a
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
1f39a9b 
…823.9

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-2.24422.8 -> To Version 4.12.0-2.24423.9
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Aug 24, 2024
This was referenced Aug 24, 2024
Open
Open
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
ff6bfe0 
…825.4

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-2.24423.9 -> To Version 4.12.0-2.24425.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
7d6391d 
…827.1

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-2.24425.4 -> To Version 4.12.0-2.24427.1
@build-analysis build-analysis bot mentioned this pull request Aug 27, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
4ed0d82 
…827.16

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-2.24427.1 -> To Version 4.12.0-3.24427.16
@build-analysis build-analysis bot mentioned this pull request Aug 28, 2024
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
127b9f9 
…828.8

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-3.24427.16 -> To Version 4.12.0-3.24428.8
@build-analysis build-analysis bot mentioned this pull request Aug 29, 2024
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
1aa6610 
…830.2

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-3.24428.8 -> To Version 4.12.0-3.24430.2
This was referenced Aug 30, 2024
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
bc54dea 
…830.8

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-3.24430.2 -> To Version 4.12.0-3.24430.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
468757b 
…902.3

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-3.24430.8 -> To Version 4.12.0-3.24452.3
@build-analysis build-analysis bot mentioned this pull request Sep 3, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
cd8a63a 
…903.6

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-3.24452.3 -> To Version 4.12.0-3.24453.6
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 4, 2024
@carlossanlop
Copy link
Member

@eerhardt @dotnet/area-extensions-configuration can you please take a look at the CI failures? They're related to Configuration.Binder and I haven't seen them before.

@tarekgh
Copy link
Member

tarekgh commented Sep 4, 2024 •
edited
Loading

@eerhardt @dotnet/area-extensions-configuration can you please take a look at the CI failures? They're related to Configuration.Binder and I haven't seen them before.

@steveharter @RikkiGibson @CyrusNajmabadi

Any idea about this failure? Generator caused diagnostic in output compilation: The 'interceptors' feature is not enabled in this namespace. Add '<InterceptorsNamespaces>$(InterceptorsNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsNamespaces>' to your project..

@RikkiGibson
Copy link
Contributor

dotnet/roslyn#74865 is the cause. Do you happen to have a link to the source of the failing test? Maybe it is adding a Features value in the ParseOptions manually?

We made a change here such that both <InterceptorsPreviewNamespaces> and <InterceptorsNamespaces> are accepted as msbuild properties, but we made a breaking change to the csc commandline so that only /features:InterceptorsNamespaces=... is accepted and not /features:InterceptorsPreviewNamespaces=....

@tarekgh
Copy link
Member

tarekgh commented Sep 4, 2024

@RikkiGibson do you think this is the problem

runtime/src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/ConfigBindingGenTestDriver.cs

Line 41 in 959c10e

_parseOptions = new CSharpParseOptions(langVersion).WithFeatures(new[] {
?

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Sep 4, 2024 •
edited
Loading

Yes. Feature name "InterceptorsPreviewNamespaces" can be changed to "InterceptorsNamespaces" in that code and everything should start working again.

Also, feature name InterceptorsPreview is not used in the compiler. That can be removed.

@eerhardt
Copy link
Member

eerhardt commented Sep 4, 2024

@RikkiGibson - is someone planning on updating the SDK for this rename?

https://github.com/dotnet/sdk/blob/115070430f986855b31d75e8fb429b415cc96076/src/WebSdk/ProjectSystem/Targets/Microsoft.NET.Sdk.Web.ProjectSystem.targets#L67-L70

tarekgh and others added 2 commits September 4, 2024 13:23
@tarekgh
Fix interceptor feature name in the configuration test
ace98cd
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
819472d 
…905.2

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-3.24453.6 -> To Version 4.12.0-3.24455.2
@carlossanlop
Copy link
Member

@tarekgh thank you for submitting a commit with a fix. It seems one leg is stuck, but the failure is gone. Ready to merge?

@tarekgh
Copy link
Member

tarekgh commented Sep 5, 2024

Ready to merge?

Fine to merge with me if no other unrelated issues.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20240…
1ddfcfb 
…906.1

Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.12.0-3.24455.2 -> To Version 4.12.0-3.24456.1
@carlossanlop carlossanlop merged commit 131408a into release/9.0 Sep 6, 2024
159 of 162 checks passed
@carlossanlop carlossanlop deleted the darc-release/9.0-c3748890-1f60-476b-a4a1-1d659fb587a5 branch September 6, 2024 17:12
This was referenced Sep 11, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @tarekgh @RikkiGibson @eerhardt