[mono] make sure that MonoBundledResource.id is valid #106205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @kg What is ASAN? |
|
asan is llvm address sanitizer, it catches various bad pointers. it can also catch leaks. a related feature is ubsan, which detects undefined behavior |
kg
approved these changes
Aug 9, 2024
kg
reviewed
Aug 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw ASAN on browser/wasm to complain about NULL derefence in
key_from_idwhile loading time zone bundle.But I was not able to reproduce it without ASAN.
This is just trying to add defensive code.