Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cdac_offsets to cdac_data #105657

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

elinor-fung
Copy link
Member

The struct is used for exposing more than just offsets to the cDAC. Follow-up for #105534 (comment)

cc @jkoritzinsky

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise LGTM

Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
@elinor-fung elinor-fung merged commit 18eba09 into dotnet:main Jul 30, 2024
90 checks passed
@elinor-fung elinor-fung deleted the rename-cdac-offsets branch July 30, 2024 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants