Fix MaxWorkingSet_GetNotStarted_ThrowsInvalidOperationException

[gwr]

Fixes #105422

[stephentoub]

Thanks

[stephentoub]

These tests needs to be addressed:

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs

Lines 659 to 673 in 54a9efd

	[Fact]
	[SkipOnPlatform(TestPlatforms.OSX | TestPlatforms.FreeBSD | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Getting MinWorkingSet is not supported on OSX, BSD, iOS, MacCatalyst, and tvOS.")]
	public void MinWorkingSet_GetNotStarted_ThrowsInvalidOperationException()
	{
	var process = new Process();
	Assert.Throws<InvalidOperationException>(() => process.MinWorkingSet);
	}
	[Fact]
	[PlatformSpecific(TestPlatforms.OSX | TestPlatforms.FreeBSD)]
	public void MinWorkingSet_GetMacos_ThrowsPlatformSupportedException()
	{
	var process = new Process();
	Assert.Throws<PlatformNotSupportedException>(() => process.MinWorkingSet);
	}

[gwr]

These tests needs to be addressed:

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs

Lines 659 to 673 in 54a9efd

	[Fact]
	[SkipOnPlatform(TestPlatforms.OSX | TestPlatforms.FreeBSD | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Getting MinWorkingSet is not supported on OSX, BSD, iOS, MacCatalyst, and tvOS.")]
	public void MinWorkingSet_GetNotStarted_ThrowsInvalidOperationException()
	{
	var process = new Process();
	Assert.Throws<InvalidOperationException>(() => process.MinWorkingSet);
	}
	[Fact]
	[PlatformSpecific(TestPlatforms.OSX | TestPlatforms.FreeBSD)]
	public void MinWorkingSet_GetMacos_ThrowsPlatformSupportedException()
	{
	var process = new Process();
	Assert.Throws<PlatformNotSupportedException>(() => process.MinWorkingSet);
	}

Yeah, the SkipOnPlatform line(s) probably need adjustment. I think these tests should now pass on FreeBSD and OSX.
Someone needs to find time to remove the OS "skip" for each of these and try the test with that fix.

[am11]

In CI, this test is failing on osx with your changes:

    System.Diagnostics.Tests.ProcessTests.MinWorkingSet_GetMacos_ThrowsPlatformSupportedException [FAIL]
      Assert.Throws() Failure: Exception type was not an exact match
      Expected: typeof(System.PlatformNotSupportedException)
      Actual:   typeof(System.InvalidOperationException)
      ---- System.InvalidOperationException : No process is associated with this object.
      Stack Trace:
        /_/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs(672,0): at System.Diagnostics.Tests.ProcessTests.MinWorkingSet_GetMacos_ThrowsPlatformSupportedException()
        
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(50,0): at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
        ----- Inner Stack Trace -----
        /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs(949,0): at System.Diagnostics.Process.EnsureState(State state)
        /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs(961,0): at System.Diagnostics.Process.EnsureState(State state)
        /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.BSD.cs(60,0): at System.Diagnostics.Process.GetWorkingSetLimits(IntPtr& minWorkingSet, IntPtr& maxWorkingSet)
        /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs(1014,0): at System.Diagnostics.Process.EnsureWorkingSetLimits()
        /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs(295,0): at System.Diagnostics.Process.get_MinWorkingSet()
        /_/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs(672,0): at System.Diagnostics.Tests.ProcessTests.<>c__DisplayClass40_0.<MinWorkingSet_GetMacos_ThrowsPlatformSupportedException>b__0()
    System.Diagnostics.Tests.ProcessTests.TestProcessRecycledPid [SKIP]

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-105424-merge-dd30dcce610b4a389e/System.Diagnostics.Process.Tests/1/console.4d1998ff.log?helixlogtype=result

[am11]

Yeah, the SkipOnPlatform line(s) probably need adjustment. I think these tests should now pass on FreeBSD and OSX.

Feel free to merge both tests into one and delete the [Skip line here.

@Thefrank, a heads-up for the next test run on FreeBSD after this PR is merged.

[gwr]

In CI, this test is failing on osx with your changes:

    System.Diagnostics.Tests.ProcessTests.MinWorkingSet_GetMacos_ThrowsPlatformSupportedException [FAIL]
    System.Diagnostics.Tests.ProcessTests.TestProcessRecycledPid [SKIP]

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-105424-merge-dd30dcce610b4a389e/System.Diagnostics.Process.Tests/1/console.4d1998ff.log?helixlogtype=result

Thanks. Clearly the fix in Process.BSD.cs needs testing on OSX and FreBSD.
I've taken a stab at what I think will be needed to fix it, pushed to the PR.

[gwr]

Is this #if 0 not allowed? I don't mean for it to stay long term, just until testing is complete.

[stephentoub]

We wouldn't merge this, if that's what you mean. If you want to experiment with it in CI, that's fine. I'm going to move the PR to be draft until it's ready.

[gwr]

OK, though I was hoping the CI stuff could help me with some of this, and now it seems that doesn't happen.

[stephentoub]

CI still runs on drafts

[gwr]

Ah, OK. I guess I misunderstood what I saw on the web page. Thx.

[gwr]

I reorganized the changes related to this so it can go after #105403

[gwr]

The relevant tests pass for me on MacOS, but see the XXX questions in this change.
Why is MacOS apparently skipping these tests when the SkipOnPlatform does not list OSX?

MaxWorkingSet_GetNotStarted_ThrowsInvalidOperationException
MinWorkingSet_GetNotStarted_ThrowsInvalidOperationException

[am11]

Why is MacOS apparently skipping these tests when the SkipOnPlatform does not list OSX?

How did you determine that they are skipping? Change the exception in Assert.Throws<InvalidOperationException> to something like InvalidCastException, if it fails osx CI that means it is running. The success logs aren’t as verbose as the failure logs.

[gwr]

Why is MacOS apparently skipping these tests when the SkipOnPlatform does not list OSX?

How did you determine that they are skipping? Change the exception in Assert.Throws<InvalidOperationException> to something like InvalidCastException, if it fails osx CI that means it is running. The success logs aren’t as verbose as the failure logs.

OK, Thank-you! That was it! So I've learned that the test output cannot be trusted to tell you want ran.
With the Assert.Throws lines changed as you suggest, I've verified that MacOS runs all of those tests.

�[m�[37m      Condition(s) not met: "IsSupported"
�[m�[31;1m    System.Diagnostics.Tests.ProcessTests.MaxWorkingSet_GetNotStarted_ThrowsInvalidOperationException [FAIL]
�[m�[37m      Assert.Throws() Failure: Exception type was not an exact match
�[m�[37m      Expected: typeof(System.InvalidCastException)
�[m�[37m      Actual:   typeof(System.InvalidOperationException)
�[m�[37m      ---- System.InvalidOperationException : No process is associated with this object.

I believe this means wen can just remove the (now duplicate) MacOS-specific tests.

[gwr]

Rebased onto main

[am11]

@stephentoub please give it another pass. :) (the temporary blocks were removed)

[gwr]

Can anyone tell me what to do about the two runtime checks that reported failure?

[gwr]

nudge 2

[gwr]

nudge 3

[am11]

Can anyone tell me what to do about the two runtime checks that reported failure?

When Build Analysis leg is green, that means the remaining ones are known failures unrelated to your changes.