Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue link for an expected difference in warning behavior #104760

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jul 11, 2024

These warnings are intentionally only produced by Native AOT. Analyzer doesn't detect reflection access to Requires* attributes other than RequiresUnreferencedCode, per discussion in dotnet/linker#2739. Replacing the issue links so we can close that issue.

Fixes dotnet/linker#2739

These warnings are intentionally only produced by Native AOT. Analyzer doesn't detect
reflection access to Requires* attributes other than RequiresUnreferencedCode.
@sbomer sbomer merged commit 8dc7b9e into dotnet:main Jul 12, 2024
59 of 76 checks passed
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linkable-framework Issues associated with delivering a linker friendly framework needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAM interaction with RequiresAttribute
3 participants