fix: reset async state of continuation in ManualResetValueTaskSourceCore<TResult>.Reset

[sator-imaging]

What's fixed

ManualResetValueTaskSourceCore<TResult>.Reset method WON'T reset asynchronous state of continuation.

• field name: _runContinuationsAsynchronously

Why need to be reset

I've wrote task instance pool using ManualResetValueTaskSourceCore, in that case, pooled task instance could behave differently depending on what previous consumer does.

Solution

core.Reset();

// reset by hand
core.RunContinuationsAsynchronously = false;

[dotnet-policy-service]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

[sator-imaging]

@dotnet-policy-service agree [company="@sator-imaging"]

[sator-imaging]

@dotnet-policy-service agree

[stephentoub]

Thanks, but it is by design that _runContinuationsAsynchronously is left untouched. That state is mutable regardless of the lifecycle of the instance and can be changed at any time. It's not changed by Reset so that you can set it once and not have to set it again every single time you call Reset, which happens per operation. If that doesn't meet your needs, you can explicitly set it after calling Reset.