Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose XmlReader in CreateRuntimeRootDescriptorFile #103239

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Dispose XmlReader in CreateRuntimeRootDescriptorFile #103239

merged 1 commit into from
Jun 13, 2024

Conversation

omajid
Copy link
Member

@omajid omajid commented Jun 10, 2024

It's an IDisposable, so we should Dispose it manually or use a using to auto-Dispose it.

@omajid
Dispose XmlReader in CreateRuntimeRootDescriptorFile
1243f2b 
It's an IDisposable, so we should Dispose it manually or use a `using`
to auto-Dispose it.
@omajid omajid requested a review from sbomer as a code owner June 10, 2024 17:50
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jun 10, 2024
@dotnet-policy-service dotnet-policy-service bot added linkable-framework Issues associated with delivering a linker friendly framework community-contribution Indicates that the PR has been added by a community member labels Jun 10, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

sbomer
sbomer approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This was referenced Jun 10, 2024
Closed
Closed
@stephentoub stephentoub merged commit 66298c7 into dotnet:main Jun 13, 2024
74 of 76 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbomer sbomer sbomer approved these changes

Assignees
No one assigned
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omajid @sbomer @stephentoub