Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT][hybridglobalization] Run HybridGlobalization threading tests #102595

Closed
wants to merge 13 commits into from
Closed

[browser][MT][hybridglobalization] Run HybridGlobalization threading tests #102595

wants to merge 13 commits into from

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented May 23, 2024 •
edited
Loading

Fixes #102305, fixes #98483.

The tests still fail on indexing/prefix/suffix functions -> segmentation rules are still not loaded properly.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization os-browser Browser variant of arch-wasm labels May 23, 2024
@ilonatommy ilonatommy self-assigned this May 23, 2024
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member

segmentation rules are still not loaded properly.

I would prefer to fix it here before we merge this.

@ilonatommy
Copy link
Member Author

This PR is not in a mergable state, sorry for confusion, I'm still working on it

@ilonatommy ilonatommy added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 27, 2024
@pavelsavara pavelsavara marked this pull request as draft May 27, 2024 11:34
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
- push worker assets into core collection
64f3044 
- wait on core promise before starting worker
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 30, 2024
Closed
Closed
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy mentioned this pull request Jun 4, 2024
Closed
4 tasks
@ilonatommy ilonatommy reopened this Jul 1, 2024
@ilonatommy ilonatommy reopened this Aug 5, 2024
@ilonatommy
Copy link
Member Author

Saving the failing log:

[10:35:41] info: Running at: http://127.0.0.1:44279/index.html?arg=--setenv%3dIsBrowserThreadingSupported%3dtrue&arg=--run&arg=WasmTestRunner.dll&arg=Microsoft.Extensions.Options.SourceGeneration.Unit.Tests.dll&arg=-threads&arg=-parallelThreads&arg=8&arg=-notrait&arg=category%3dIgnoreForCI&arg=-notrait&arg=category%3dOuterLoop&arg=-notrait&arg=category%3dfailing&arg=-verbosity&arg=Info
[10:35:41] fail: [out of order message from the browser]: http://127.0.0.1:44279/runArgs.json - Failed to load resource: the server responded with a status of 404 (Not Found)
[10:35:41] info: could not load /runArgs.json: 404. Ignoring
[10:35:41] info: Incoming arguments: --setenv=IsBrowserThreadingSupported=true --run WasmTestRunner.dll Microsoft.Extensions.Options.SourceGeneration.Unit.Tests.dll -threads -parallelThreads 8 -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing -verbosity Info
[10:35:41] info: Application arguments: --run WasmTestRunner.dll Microsoft.Extensions.Options.SourceGeneration.Unit.Tests.dll -threads -parallelThreads 8 -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing -verbosity Info
[10:35:42] fail: [--021d6038-emsc 10:35:41.989] MONO_WASM: mono_wasm_pthread_on_pthread_created () failed TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [--021d6038-emsc 10:35:42.039] MONO_WASM: at.getSegmentationRules is not a function
                 TypeError: at.getSegmentationRules is not a function
                     at http://127.0.0.1:44279/_framework/dotnet.runtime.js:3:59252
                     at e.threadInitTLS (http://127.0.0.1:44279/_framework/dotnet.runtime.js:3:59431)
                     at handleMessage (http://127.0.0.1:44279/_framework/dotnet.native.worker.mjs:1:2295)
[10:35:42] fail: [--000fb4f8-emsc 10:35:42.070] MONO_WASM: Uncaught TypeError: at.getSegmentationRules is not a function
                 Error
                     at Object.uo [as mono_exit] (http://127.0.0.1:44279/_framework/dotnet.js:3:27332)
                     at st.config.exitOnUnhandledError.e.onerror (http://127.0.0.1:44279/_framework/dotnet.runtime.js:3:31939)
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/index.html?arg=--setenv%3dIsBrowserThreadingSupported%3dtrue&arg=--run&arg=WasmTestRunner.dll&arg=Microsoft.Extensions.Options.SourceGeneration.Unit.Tests.dll&arg=-threads&arg=-parallelThreads&arg=8&arg=-notrait&arg=category%3dIgnoreForCI&arg=-notrait&arg=category%3dOuterLoop&arg=-notrait&arg=category%3dfailing&arg=-verbosity&arg=Info 0:0 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2 Uncaught (in promise) TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2 Uncaught (in promise) TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2 Uncaught (in promise) TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2 Uncaught (in promise) TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2 Uncaught (in promise) TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2 Uncaught (in promise) TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.js 7:1226 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2 Uncaught (in promise) TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.js 2:472 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.runtime.js 2:221141 Uncaught ErrorEvent: Uncaught TypeError: at.getSegmentationRules is not a function
[10:35:42] fail: [out of order message from the browser]: http://127.0.0.1:44279/_framework/dotnet.native.worker.mjs 0 Uncaught TypeError: at.getSegmentationRules is not a function

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[browser][MT][hybridglobalization] Run HybridGlobalization MT tests [browser][MT] hybrid globalization
2 participants
@ilonatommy @pavelsavara