Update auto-generated native AOT metadata wrappers to use readonly structs #101895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structs This avoids defensive copies when these types are used for readonly fields Also deleted some unused methods and unused arguments, and make the auto-generated code more compact.
jkotas
changed the title
As observed in #101890 (comment). The crash during defensive copy of 100 byte struct. |
jkotas
commented
May 6, 2024
| @@ -88,7 +88,7 @@ public sealed override MethodInfo EntryPoint | |||
| MetadataReader reader = scope.Reader; | |||
|
|
|||
| QualifiedMethodHandle entrypointHandle = scope.ScopeDefinition.EntryPoint; | |||
| if (!entrypointHandle.IsNull(reader)) | |||
| if (!entrypointHandle.IsNil) | |||
There was a problem hiding this comment.
IsNil matches the naming convention and shape of System.Reflection.Metadata.
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…ructs (dotnet#101895) This avoids defensive copies when these types are used for readonly fields Also deleted some unused methods and unused arguments, and make the auto-generated code more compact.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…ructs (dotnet#101895) This avoids defensive copies when these types are used for readonly fields Also deleted some unused methods and unused arguments, and make the auto-generated code more compact.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids defensive copies when these types are used for readonly fields
Also deleted some unused methods and unused arguments, and make the auto-generated code more compact.