Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Http3LoopbackServer sending GOAWAY cancelling completed request/response. #101447

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Apr 23, 2024

Failure scenario: server is fast, the AcceptConnectionAsync processes faster than client can receive the response. Server code then calls SendResponseBodyAsync(final: true) which disposes of the stream and bumps down _currentStreamId, Following GOAWAY frame has first rejected stream id equal to 0, which fails HttpClient. Client then retries the request but the server is not serving anymore and test times out.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@rzikm rzikm changed the title Fix failing ReadAsStreamAsync_HandlerProducesWellBehavedResponseStream for Http3 Fix Http3LoopbackServer sending GOAWAY cancelling completed request/response. Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants