Make JitOptRepeat available in Release builds #100494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@AndyAyersMS PTAL |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
AndyAyersMS
approved these changes
Apr 1, 2024
EgorBo
reviewed
Apr 1, 2024
|
|
||
| CONFIG_INTEGER(JitDoIfConversion, W("JitDoIfConversion"), 1) // Perform If conversion | ||
|
|
||
| #endif // defined(OPT_CONFIG) | ||
|
|
||
| CONFIG_INTEGER(JitEnableOptRepeat, W("JitEnableOptRepeat"), 0) // If zero, do not allow JitOptRepeat | ||
| CONFIG_METHODSET(JitOptRepeat, W("JitOptRepeat")) // Runs optimizer multiple times on specified methods |
There was a problem hiding this comment.
I wonder - maybe it's worth making its default value * so it will be enough to only define DOTNET_JitEnableOptRepeat ?
There was a problem hiding this comment.
METHODSET doesn't have a default value.
I thought about getting rid of DOTNET_JitEnableOptRepeat but after #94250 is merged, which enables OptRepeat in stress, I want a way to disable OptRepeat in stress.
Maybe we could instead have (after #94250 is merged):
- Default: OptRepeat enabled in stress.
DOTNET_JitOptRepeat=method set: enable OptRepeat for exactly the specified methodsDOTNET_JitEnableOptRepeat=0: disable OptRepeat in stress. Or maybe name itDOTNET_JitEnableOptRepeatStressto be clear that's all it affects?- But, perhaps weirdly, if you set
DOTNET_JitOptRepeat=*andDOTNET_JitEnableOptRepeat=0, we still enable OptRepeat? (Maybe leaning towards renaming to DOTNET_JitEnableOptRepeatStress?)
- But, perhaps weirdly, if you set
EgorBo
approved these changes
Apr 1, 2024
Also, fix a problem in superpmi.py asmdiffs for Release builds where we got a divide by zero because release builds don't have PerfScore.
BruceForstall
force-pushed
the
MakeOptRepeatAvailableInRelease
branch
from
fa9652d to
e6004c3
Compare
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Also, fix a problem in superpmi.py asmdiffs for Release builds where we got a divide by zero because release builds don't have PerfScore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix a problem in superpmi.py asmdiffs for Release builds where we got a divide by zero because release builds don't have PerfScore.