-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] invocation of user JS in UI thread till next event loop tick #100040
Merged
pavelsavara
merged 3 commits into
dotnet:main
from
pavelsavara:browser_mt_enable_fs_in_sync
Mar 21, 2024
Merged
[browser][MT] invocation of user JS in UI thread till next event loop tick #100040
pavelsavara
merged 3 commits into
dotnet:main
from
pavelsavara:browser_mt_enable_fs_in_sync
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new invoke_later_when_on_ui_thread_sync and invoke_later_when_on_ui_thread_async which postpone invocation of user code till next event loop tick - rename mono_wasm_invoke_jsimport_MT - test in browser-threads sample, more tests in next PR
pavelsavara
added
arch-wasm
WebAssembly architecture
area-VM-threading-mono
os-browser
Browser variant of arch-wasm
labels
Mar 20, 2024
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
changed the title
[browser][MT] postpone invocation of user JS in UI thread till next event loop tick
[browser][MT] invocation of user JS in UI thread till next event loop tick
Mar 20, 2024
radekdoulik
reviewed
Mar 21, 2024
radekdoulik
approved these changes
Mar 21, 2024
maraf
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to rewrite the sample as WBT test app 🤞
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postpone invocation of user JS in UI thread till next event loop tick, so that
em_task_queue_execute
is not blocked by it.That allows
emscripten_yield
to process FS POSIX calls even if the UI is spin-waiting for the return from synchonous call toJSExport
SyncDoneSemaphorePtr
invoke_later_when_on_ui_thread_sync
invoke_later_when_on_ui_thread_async
which postpone invocation of user code till next event loop tickmono_wasm_invoke_jsimport_MT
browser-threads
sample, more tests in next PR