Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: JIT/Directed/tailcall/more_tailcalls/more_tailcalls.cmd #99410

Closed
BruceForstall opened this issue Mar 7, 2024 · 3 comments · Fixed by #106287
Closed

Test failure: JIT/Directed/tailcall/more_tailcalls/more_tailcalls.cmd #99410

BruceForstall opened this issue Mar 7, 2024 · 3 comments · Fixed by #106287
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged JitStress CLR JIT issues involving JIT internal stress modes Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@BruceForstall
Copy link
Member

Test timeout

Pipeline: runtime-coreclr gcstress0x3-gcstress0xc
Job: coreclr linux arm Checked gcstress0xc

https://dev.azure.com/dnceng-public/public/_build/results?buildId=592477&view=ms.vss-test-web.build-test-results-tab

03:24:36.395 Running test: JIT/Directed/tailcall/more_tailcalls/more_tailcalls.cmd
Invoking: sudo ls -l /home/helixbot/dotnetbuild/dumps/coredump.226.dmp.crashreport.json
stdout: -rw------- 1 helixbot2 adm 24482 Mar  7 03:24 /home/helixbot/dotnetbuild/dumps/coredump.226.dmp.crashreport.json

=========================================
Child process took too long. Timed out... Exiting...
App Exit Code: 110
Expected: 100
Actual: 110
END EXECUTION - FAILED

Failing since 20240302.1

cc @janvorli
@BruceForstall BruceForstall added JitStress CLR JIT issues involving JIT internal stress modes area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 7, 2024
@BruceForstall BruceForstall added this to the 9.0.0 milestone Mar 7, 2024
@BruceForstall
Copy link
Member Author

Three additional failures in gcstress-extra:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=592476&view=ms.vss-test-web.build-test-results-tab

coreclr linux arm Checked gcstress0xc_disabler2r_heapverify1
coreclr linux arm Checked gcstress0xc_disabler2r
coreclr linux arm Checked gcstress0xc_tailcallstress

@janvorli janvorli mentioned this issue Mar 15, 2024
Merged
@BruceForstall BruceForstall mentioned this issue Mar 18, 2024
Closed
@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib This is a GCStress issue apparently related to tailcall.

@BruceForstall BruceForstall added the blocking-clean-ci-optional Blocking optional rolling runs label Mar 18, 2024
@janvorli janvorli mentioned this issue Mar 20, 2024
Merged
@janvorli janvorli mentioned this issue Mar 27, 2024
Merged
This was referenced Apr 2, 2024
Closed
Merged
@jakobbotsch jakobbotsch added the disabled-test The test is disabled in source code against the issue label Apr 2, 2024
@SingleAccretion
Copy link
Contributor

SingleAccretion commented Apr 3, 2024 •
edited
Loading

I wonder if this could have something to do with the recent conversion of copy helpers to managed code.

Stack args for fast tail calls are set up in a no-gc region. If a copy helper that calls managed code ends up in this region, problems will follow.

@jakobbotsch jakobbotsch removed the blocking-clean-ci-optional Blocking optional rolling runs label Apr 4, 2024
@jakobbotsch jakobbotsch added the Priority:2 Work that is important, but not critical for the release label Apr 29, 2024
@EgorBo EgorBo mentioned this issue May 5, 2024
Closed
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Aug 12, 2024
@jakobbotsch
Reenable more_tailcalls under GCStress
6a929de 
Fix dotnet#99410
@jakobbotsch jakobbotsch mentioned this issue Aug 12, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged JitStress CLR JIT issues involving JIT internal stress modes Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Reenable more_tailcalls under GCStress jakobbotsch/runtime
3 participants
@jakobbotsch @BruceForstall @SingleAccretion