JsonConsoleFormatter memory optimization opportunity

[cd21h]

There is an opportunity to remove memory application by replacing string with shared buffer:

runtime/src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs

Line 79 in 2df640c

textWriter.Write(Encoding.UTF8.GetString(output.WrittenMemory.Span));

textWriter.Write(Encoding.UTF8.GetString(output.WrittenMemory.Span));

can be replaced with

var messageBytes = writerBuffer.WrittenMemory.Span;
buffer = ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetCharCount(messageBytes));
var charsWritten = Encoding.UTF8.GetChars(messageBytes, buffer);
textWriter.Write(buffer, 0, charsWritten);
ArrayPool<char>.Shared.Return(buffer);

[ghost]

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There is an opportunity to remove memory application by replacing string with shared buffer:

runtime/src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs

Line 79 in 2df640c

textWriter.Write(Encoding.UTF8.GetString(output.WrittenMemory.Span));

textWriter.Write(Encoding.UTF8.GetString(output.WrittenMemory.Span));

can be replaced with

var messageBytes = writerBuffer.WrittenMemory.Span;
buffer = ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetCharCount(messageBytes));
var charsWritten = Encoding.UTF8.GetChars(messageBytes, buffer);
textWriter.Write(buffer, 0, charsWritten);
ArrayPool<char>.Shared.Return(buffer);

Author:	shatl
Assignees:	-
Labels:	area-System.Memory
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There is an opportunity to remove memory application by replacing string with shared buffer:

runtime/src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs

Line 79 in 2df640c

textWriter.Write(Encoding.UTF8.GetString(output.WrittenMemory.Span));

textWriter.Write(Encoding.UTF8.GetString(output.WrittenMemory.Span));

can be replaced with

var messageBytes = writerBuffer.WrittenMemory.Span;
buffer = ArrayPool<char>.Shared.Rent(Encoding.UTF8.GetCharCount(messageBytes));
var charsWritten = Encoding.UTF8.GetChars(messageBytes, buffer);
textWriter.Write(buffer, 0, charsWritten);
ArrayPool<char>.Shared.Return(buffer);

Author:	shatl
Assignees:	-
Labels:	untriaged, area-Extensions-Logging
Milestone:	-

[tarekgh]

@Shatl the suggested code will not compile for netstandard2.0/NET Framework. But it is possible to optimize it for these two targets by using unsafe code. Are you interested to submit a PR for that?

[cd21h]

Will do