-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-Up: Issue-URL Cleanup #93172
Comments
/area:Meta |
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsFollow-up 2023 for #63902 As discussed in mentioned issue, I periodically review the issue comments in the current codebase. @jeffhandley Should we do this like we did last year? Just create issues for all points? Closedi ssues resultsFile runtime/docs/design/features/additional-deps.md Lines 3 to 7 in f21a266
File runtime/src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextWriter.cs Lines 19 to 23 in f21a266
File runtime/src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonWriterTests.cs Lines 189 to 193 in f21a266
File runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Helpers.cs Lines 244 to 248 in f21a266
File Lines 77 to 81 in f21a266
File Lines 4592 to 4596 in f21a266
File runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs Lines 1331 to 1335 in f21a266
File Lines 72 to 76 in f21a266
File runtime/src/mono/mono/utils/mono-threads-windows.c Lines 111 to 115 in f21a266
File Lines 24 to 28 in f21a266
File runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs Lines 375 to 379 in f21a266
File Lines 18 to 22 in f21a266
File runtime/src/libraries/System.Runtime/tests/System/TupleTests.cs Lines 218 to 222 in f21a266
File runtime/src/libraries/System.ValueTuple/tests/ValueTupleTests.cs Lines 223 to 227 in f21a266
File runtime/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Lines 401 to 405 in f21a266
File runtime/src/tests/JIT/SIMD/Vector3GetHash.cs Lines 5 to 9 in f21a266
File Lines 153 to 157 in f21a266
File runtime/src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs Lines 14 to 18 in f21a266
File Lines 53 to 57 in f21a266
File runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs Lines 916 to 920 in f21a266
File runtime/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs Lines 8 to 12 in f21a266
File Lines 118 to 122 in f21a266
File runtime/eng/codeOptimization.targets Lines 8 to 12 in f21a266
File runtime/src/coreclr/jit/CMakeLists.txt Lines 7 to 11 in f21a266
File runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs Lines 60 to 64 in f21a266
File Lines 45 to 49 in f21a266
File runtime/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs Lines 202 to 206 in f21a266
File runtime/src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs Lines 214 to 218 in f21a266
File Lines 43 to 47 in f21a266
File runtime/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs Lines 511 to 515 in f21a266
File Lines 470 to 474 in f21a266
File Lines 2191 to 2195 in f21a266
File runtime/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj Lines 8 to 12 in f21a266
File runtime/src/libraries/System.Net.Quic/src/System.Net.Quic.csproj Lines 41 to 45 in f21a266
File runtime/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ValueListBuilder.cs Lines 46 to 50 in f21a266
File
File runtime/src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs Lines 19 to 23 in f21a266
File Lines 24 to 28 in f21a266
File Lines 18 to 22 in f21a266
File runtime/src/coreclr/tools/aot/AotCompilerCommon.props Lines 8 to 12 in f21a266
|
Follow-up 2023 for #63902
As discussed in mentioned issue, I periodically review the issue comments in the current codebase.
To avoid confusion here, weshould of course remove these occurences when the related issue is resolved.
@jeffhandley Should we do this like we did last year? Just create issues for all points?
Would you take a quick look over and see if something could be taken out of here?
New
File
docs/design/features/additional-deps.md
(File Position 221-266)runtime/docs/design/features/additional-deps.md
Lines 3 to 7 in f21a266
dotnet test
#3678File
src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextWriter.cs
(File Position 641-686)runtime/src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextWriter.cs
Lines 19 to 23 in f21a266
src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonWriterTests.cs
(File Position 9033-9078)runtime/src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonWriterTests.cs
Lines 189 to 193 in f21a266
File
src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Helpers.cs
(File Position 12599-12645)runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Helpers.cs
Lines 244 to 248 in f21a266
File
src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/AllocFreeConcurrentStack.cs
(File Position 2575-2621)runtime/src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/AllocFreeConcurrentStack.cs
Lines 77 to 81 in f21a266
File
src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs
(File Position 3262-3308)runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs
Lines 60 to 64 in f21a266
File
src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs
(File Position 7634-7680)runtime/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs
Lines 202 to 206 in f21a266
File
src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs
(File Position 9323-9369)runtime/src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs
Lines 214 to 218 in f21a266
File
src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj
(File Position 2303-2349)runtime/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj
Lines 43 to 47 in f21a266
File
src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs
(File Position 22234-22281)runtime/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs
Lines 511 to 515 in f21a266
File
src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs
(File Position 18079-18125)runtime/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs
Lines 470 to 474 in f21a266
File
src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
(File Position 105461-105508)runtime/src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
Lines 2191 to 2195 in f21a266
File
src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
(File Position 259-305)runtime/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj
Lines 8 to 12 in f21a266
File
src/libraries/System.Net.Quic/src/System.Net.Quic.csproj
(File Position 3689-3735)runtime/src/libraries/System.Net.Quic/src/System.Net.Quic.csproj
Lines 41 to 45 in f21a266
File
src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ValueListBuilder.cs
(File Position 1220-1266)runtime/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ValueListBuilder.cs
Lines 46 to 50 in f21a266
File
src/mono/wasm/Wasm.Build.Tests/data/RunScriptTemplate.sh
(File Position 62-108)runtime/src/mono/wasm/Wasm.Build.Tests/data/RunScriptTemplate.sh
Lines 1 to 5 in f21a266
File
src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs
(File Position 747-793)runtime/src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs
Lines 19 to 23 in f21a266
File
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlDecryptionTransform.cs
(File Position 1185-1231)runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlDecryptionTransform.cs
Lines 24 to 28 in f21a266
File
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlLicenseTransform.cs
(File Position 796-842)runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlLicenseTransform.cs
Lines 18 to 22 in f21a266
File
src/coreclr/tools/aot/AotCompilerCommon.props
(File Position 350-396)runtime/src/coreclr/tools/aot/AotCompilerCommon.props
Lines 8 to 12 in f21a266
Handled before
% 0
workaround inMicrosoft.VisualBasic.CompilerServices
#65230File
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb
(File Position 225458-225503)runtime/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb
Lines 4592 to 4596 in f21a266
File
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs
(File Position 59646-59692)runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs
Lines 1331 to 1335 in f21a266
File
src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs
(File Position 3236-3283)runtime/src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs
Lines 72 to 76 in f21a266
File
src/mono/mono/utils/mono-threads-windows.c
(File Position 4766-4813)runtime/src/mono/mono/utils/mono-threads-windows.c
Lines 111 to 115 in f21a266
File
src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.NonMobile.cs
(File Position 1064-1110)runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.NonMobile.cs
Lines 24 to 28 in f21a266
File
src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs
(File Position 13300-13346)runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs
Lines 375 to 379 in f21a266
ParameterInfo.HasDefaultValue
workaround #65233File
src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs
(File Position 685-731)runtime/src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs
Lines 18 to 22 in f21a266
File
src/libraries/System.Runtime/tests/System/TupleTests.cs
(File Position 11829-11875)runtime/src/libraries/System.Runtime/tests/System/TupleTests.cs
Lines 218 to 222 in f21a266
File
src/libraries/System.ValueTuple/tests/ValueTupleTests.cs
(File Position 12672-12718)runtime/src/libraries/System.ValueTuple/tests/ValueTupleTests.cs
Lines 223 to 227 in f21a266
File
src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
(File Position 18743-18790)runtime/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
Lines 401 to 405 in f21a266
File
src/tests/JIT/SIMD/Vector3GetHash.cs
(File Position 379-425)runtime/src/tests/JIT/SIMD/Vector3GetHash.cs
Lines 5 to 9 in f21a266
File
src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs
(File Position 7332-7378)runtime/src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs
Lines 153 to 157 in f21a266
File
src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs
(File Position 586-633)runtime/src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs
Lines 14 to 18 in f21a266
File
src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs
(File Position 1871-1917)runtime/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs
Lines 53 to 57 in f21a266
File
src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs
(File Position 39444-39490)runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs
Lines 916 to 920 in f21a266
File
src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs
(File Position 351-397)runtime/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs
Lines 8 to 12 in f21a266
File
src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs
(File Position 5050-5096)runtime/src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs
Lines 118 to 122 in f21a266
File
eng/codeOptimization.targets
(File Position 731-777)runtime/eng/codeOptimization.targets
Lines 8 to 12 in f21a266
File
src/coreclr/jit/CMakeLists.txt
(File Position 388-434)runtime/src/coreclr/jit/CMakeLists.txt
Lines 7 to 11 in f21a266
File
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs
(File Position 3243-3289)runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs
Lines 45 to 49 in f21a266
The text was updated successfully, but these errors were encountered: