Remove ParameterInfo.HasDefaultValue workaround

[deeprobin]

Follow-up issue of #18844

---

As described in #63902, it would be good to remove comments and workarounds that have already been fixed.

So this workaround could be imo removed:

runtime/src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs

Lines 22 to 26 in f04a242

	catch (FormatException) when (parameter.ParameterType == typeof(DateTime))
	{
	// Workaround for https://github.com/dotnet/runtime/issues/18844
	// If HasDefaultValue throws FormatException for DateTime
	// we expect it to have default value

I saw that there was a PR about this some time ago, which was closed due to compatibility issues with .NET 4.8.

Is this still the case?
If not, we could actually reactivate the PR (#42491).
If yes, maybe we should consider if a conditional compilation would make sense and that we only use the workaround under .NET 4.8.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Follow-up issue of #18844

---

As described in #63902, it would be good to remove comments and workarounds that have already been fixed.

So this workaround could be imo removed:

runtime/src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs

Lines 22 to 26 in f04a242

	catch (FormatException) when (parameter.ParameterType == typeof(DateTime))
	{
	// Workaround for https://github.com/dotnet/runtime/issues/18844
	// If HasDefaultValue throws FormatException for DateTime
	// we expect it to have default value

I saw that there was a PR about this some time ago, which was closed due to compatibility issues with .NET 4.8.

Is this still the case?
If not, we could actually reactivate the PR (#42491).
If yes, maybe we should consider if a conditional compilation would make sense and that we only use the workaround under .NET 4.8.

Author:	deeprobin
Assignees:	-
Labels:	untriaged, area-Extensions-DependencyInjection
Milestone:	-

[eerhardt]

This code is in the .netstandard.cs file. The workaround has been removing on .NET Core, where the bug was fixed. But since we need to support netstandard (i.e. .NET Framework), we need to keep the workaround in place because the underlying issue isn't fixed there.