Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ppc64le] Common.Tests and more tests are failing for missing opcode 'rcompare' on Power. #84401

Closed
vikasgupta8 opened this issue Apr 6, 2023 · 4 comments · Fixed by #84418
Closed

[ppc64le] Common.Tests and more tests are failing for missing opcode 'rcompare' on Power. #84401

vikasgupta8 opened this issue Apr 6, 2023 · 4 comments · Fixed by #84418
Labels
area-Codegen-JIT-mono

Comments

@vikasgupta8
Copy link
Contributor

vikasgupta8 commented Apr 6, 2023 •
edited
Loading

Description

The Common.Tests and more tests are failing in CI pipeline with below error.

Opcode 'rcompare' missing from machine description file.

Detail:

Console log: 'Common.Tests' from job eeb16027-4beb-4fd6-90c3-c27927786054 workitem 3bb2a0bd-4359-40c1-a4a4-5b0a495474d9 (ubuntu.2004.ppc64le.experimental.open) executed on machine dotnet-2 running Linux-5.4.0-146-generic-ppc64le-with-glibc2.29
+ ./RunTests.sh --runtime-path /home/helixbot/work/B37C091D/p
----- start Mon 03 Apr 2023 07:23:20 PM UTC =============== To repro directly: =====================================================
pushd .
/home/helixbot/work/B37C091D/p/dotnet exec --runtimeconfig Common.Tests.runtimeconfig.json --depsfile Common.Tests.deps.json xunit.console.dll Common.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
~/work/B37C091D/w/AE690932/e ~/work/B37C091D/w/AE690932/e
Opcode 'rcompare' missing from machine description file.

=================================================================
	Native Crash Reporting
=================================================================
Got a SIGABRT while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries 
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x7da4716ba2a8 - Unknown
	0x7da47166884c - Unknown
	0x7da4716b9768 - Unknown
	0x7da4721804c8 - Unknown
	0x7da471aed168 - Unknown
	0x7da471ac4850 - Unknown

Reproduction Steps

Run the runtime testcases.

Expected behavior

All the tests should pass without any failure or crash.

Actual behavior

Tests are failing with crash due to missing opcode 'rcompare'.

Regression?

No response

Known Workarounds

No response

Configuration

No response
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 6, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 6, 2023
@Sapana-Khemkar
Copy link
Contributor

@vargaz We have noticed that these tests are failing after #82005 is merged.
I can see opcode rcompare is not implemented for power. I am trying to understand why your changes triggered. Can you please help me understanding this.

@vargaz vargaz mentioned this issue Apr 6, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 6, 2023
vargaz added a commit to vargaz/runtime that referenced this issue Apr 6, 2023
@vargaz
[mono][jit] Revert parts of '[mono] Remove the support for non r4fp, …
0ed2fa1 
…its not used by any supported platforms. (dotnet#82005)'

Some platforms don't support r4fp, so put back the general JIT support code.
Force r4fp on platforms that support it.

Fixes dotnet#84401.
@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 6, 2023
vargaz added a commit that referenced this issue Apr 6, 2023
@vargaz
[mono][jit] Revert parts of '[mono] Remove the support for non r4fp, …
15c253f 
…its not used by any supported platforms. (#82005)' (#84418)

Some platforms don't support r4fp, so put back the general JIT support code.
Force r4fp on platforms that support it.

Fixes #84401.
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Apr 6, 2023
@vikasgupta8
Copy link
Contributor Author

vikasgupta8 commented Apr 7, 2023 •
edited
Loading

Hi @vargaz , I could see pipeline build is failing with below error after reverting part of #82005

[ 83%] Building C object mono/mini/CMakeFiles/monosgen-objects.dir/seq-points.c.o

/__w/1/s/src/mono/mono/mini/mini.c:3141:13: error: use of undeclared identifier 'llvm'

g_assert (!llvm);

^

I could see the change assert(!llvm) was not there earlier. Could you please check.

#ifdef MONO_ARCH_FLOAT32_SUPPORTED
	/* Force float32 mode on platforms where its supported */
	opts |= MONO_OPT_FLOAT32;
#else
	opts &= ~MONO_OPT_FLOAT32;
	g_assert (!llvm);
#endif

@vargaz
Copy link
Contributor

vargaz commented Apr 7, 2023

Should be fixed now.

@vikasgupta8
Copy link
Contributor Author

llvm issue is fixed in https://github.com/dotnet/runtime/pull/84473/files

@ghost ghost locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
No milestone
5 participants
@vargaz @vcsjones @jeffschwMSFT @vikasgupta8 @Sapana-Khemkar