Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete doesFieldBelongToClass #69900

Closed
SingleAccretion opened this issue May 27, 2022 · 2 comments · Fixed by #70180
Closed

Delete doesFieldBelongToClass #69900

SingleAccretion opened this issue May 27, 2022 · 2 comments · Fixed by #70180
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@SingleAccretion
Copy link
Contributor

With #68712 and #68986, there is no longer a need for it.

Ref: #68986 (comment).
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 27, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@SingleAccretion SingleAccretion added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2022
@ghost
Copy link

ghost commented May 27, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

With #68712 and #68986, there is no longer a need for it.

Ref: #68986 (comment).

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@SingleAccretion SingleAccretion added this to the Future milestone May 27, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 27, 2022
This was referenced Jun 2, 2022
Merged
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 2, 2022
trylek added a commit to trylek/runtime that referenced this issue Jun 2, 2022
@trylek
Mop-up changes per Jakob's PR suggestions
8f7697e 
1) Rename CORINFO_HELP_STATIC_VIRTUAL_AMBIGUOUS_RESOLUTION to
CORINFO_HELP_THROW_AMBIGUOUS_RESOLUTION_EXCEPTION and put it next
to the other CORINFO_HELP_THROW methods;

2) Add the new helper to CorInfoHelpFunc.cs;

3) Remove the jitinterface member doesFieldBelongToClass;

4) Update the JIT EE GUID.

Thanks

Tomas

Fixes: dotnet#69900
@trylek trylek mentioned this issue Jun 2, 2022
Merged
jakobbotsch pushed a commit that referenced this issue Jun 7, 2022
@trylek
Mop-up changes per Jakob's PR suggestions (#70180)
86a59cd 
1) Rename CORINFO_HELP_STATIC_VIRTUAL_AMBIGUOUS_RESOLUTION to
CORINFO_HELP_THROW_AMBIGUOUS_RESOLUTION_EXCEPTION and put it next
to the other CORINFO_HELP_THROW methods;

2) Add the new helper to CorInfoHelpFunc.cs;

3) Remove the jitinterface member doesFieldBelongToClass;

4) Update the JIT EE GUID.

Thanks

Tomas

Fixes: #69900
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Mop-up changes per Jakob's PR suggestions trylek/runtime
1 participant
@SingleAccretion