Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM AOT runs into issues when processing System.Runtime.Experimental #55767

Closed
tannergooding opened this issue Jul 15, 2021 · 3 comments · Fixed by #57071
Closed

WASM AOT runs into issues when processing System.Runtime.Experimental #55767

tannergooding opened this issue Jul 15, 2021 · 3 comments · Fixed by #57071
Assignees
@lambdageek
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono wasm-aot-test WebAssembly AOT Test
Milestone
Future

Comments

@tannergooding
Copy link
Member

As per #55678 (comment), WASM AOT is running into issues when running the System.Runtime.Experimental tests.

This is possibly related to the experimental ref assembly and other wonkiness with how things are configured. This does not appear to impact the non-experimental System.Runtime tests.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 15, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@tannergooding
Copy link
Member Author

CC. @lambdageek

@lambdageek lambdageek added wasm-aot-test WebAssembly AOT Test arch-wasm WebAssembly architecture area-Infrastructure-mono labels Jul 15, 2021
@ghost
Copy link

ghost commented Jul 15, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As per #55678 (comment), WASM AOT is running into issues when running the System.Runtime.Experimental tests.

This is possibly related to the experimental ref assembly and other wonkiness with how things are configured. This does not appear to impact the non-experimental System.Runtime tests.

Author: tannergooding
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono, untriaged, wasm-aot-test
Milestone: -

@lewing lewing added this to the Future milestone Jul 15, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jul 15, 2021
@tannergooding tannergooding mentioned this issue Jul 15, 2021
Merged
@MaximLipnin MaximLipnin mentioned this issue Jul 21, 2021
Closed
lambdageek added a commit to lambdageek/runtime that referenced this issue Aug 9, 2021
@lambdageek
Don't include reference assembly when publishing
4b8441c 
Fixes build failures on WebAssembly, ios and Android

Fixes dotnet#55823
Fixes dotnet#55767
@lambdageek lambdageek mentioned this issue Aug 9, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 9, 2021
lambdageek added a commit that referenced this issue Aug 10, 2021
@lambdageek
generic math: Don't include System.Runtime reference assembly when pu…
a84eee3 
…blishing (#57071)

System.Runtime.Experimental.csproj builds a reference assembly called System.Runtime.dll that should be used when compiling, but should not be included when packaging. For normal out of tree projects this happens because the System.Runtime.Experimental.nupkg makes it evident that <PackageReference Include="System.RuntimeExperimental" /> only provides reference assembly assets. But in-tree for <ProjectReference> we have to be explicit.

Fixes #55823
Fixes #55767
Fixes #56836
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lambdageek lambdageek

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono wasm-aot-test WebAssembly AOT Test
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

generic math: Don't include System.Runtime reference assembly when publishing lambdageek/runtime
3 participants
@lewing @lambdageek @tannergooding