Mono's RuntimeAssembly.GetName calls CodeBase

[eerhardt]

CodeBase is marked as RequiresAssemblyFiles, which means that it can throw an exception if the application is published as a single-file application.

runtime/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs

Lines 253 to 256 in bde0322

	public override AssemblyName GetName(bool copiedName)
	{
	return AssemblyName.Create(_mono_assembly, CodeBase);
	}

We should decide what to do here for Mono. In CoreCLR, we don't call CodeBase directly, but instead we call the underlying GetCodeBase() method, which returns null when running in a single-file application:

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs

Lines 102 to 117 in bde0322

	// If the assembly is copied before it is loaded, the codebase will be set to the
	// actual file loaded if copiedName is true. If it is false, then the original code base
	// is returned.
	public override AssemblyName GetName(bool copiedName)
	{
	string? codeBase = GetCodeBase();
	var an = new AssemblyName(GetSimpleName(),
	GetPublicKey(),
	null, // public key token
	GetVersion(),
	GetLocale(),
	GetHashAlgorithm(),
	AssemblyVersionCompatibility.SameMachine,
	codeBase,
	GetFlags() | AssemblyNameFlags.PublicKey);

Maybe we should do the same?

cc @akoeplinger @steveisok

[ghost]

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

---

CodeBase is marked as RequiresAssemblyFiles, which means that it can throw an exception if the application is published as a single-file application.

runtime/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs

Lines 253 to 256 in bde0322

	public override AssemblyName GetName(bool copiedName)
	{
	return AssemblyName.Create(_mono_assembly, CodeBase);
	}

We should decide what to do here for Mono. In CoreCLR, we don't call CodeBase directly, but instead we call the underlying GetCodeBase() method, which returns null when running in a single-file application:

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs

Lines 102 to 117 in bde0322

	// If the assembly is copied before it is loaded, the codebase will be set to the
	// actual file loaded if copiedName is true. If it is false, then the original code base
	// is returned.
	public override AssemblyName GetName(bool copiedName)
	{
	string? codeBase = GetCodeBase();
	var an = new AssemblyName(GetSimpleName(),
	GetPublicKey(),
	null, // public key token
	GetVersion(),
	GetLocale(),
	GetHashAlgorithm(),
	AssemblyVersionCompatibility.SameMachine,
	codeBase,
	GetFlags() | AssemblyNameFlags.PublicKey);

Maybe we should do the same?

cc @akoeplinger @steveisok

Author:	eerhardt
Assignees:	-
Labels:	area-System.Reflection-mono, runtime-mono
Milestone:	-

[steveisok]

/cc @lambdageek

[eerhardt]

I needed to suppress the new IL3002 warning from the RequiresAssemblyFiles analyzer in #54741.

[lambdageek]

Fixed by #54895