Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparer_get_Default test is too slow under GCStress=3 #50594

Closed
BruceForstall opened this issue Apr 1, 2021 · 0 comments · Fixed by #50602
Closed

Comparer_get_Default test is too slow under GCStress=3 #50594

BruceForstall opened this issue Apr 1, 2021 · 0 comments · Fixed by #50602
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Milestone
6.0.0

Comments

@BruceForstall
Copy link
Member

It fails with timeout under COMPlus_GCStress=3.

https://dev.azure.com/dnceng/public/_build/results?buildId=1060351&view=ms.vss-test-web.build-test-results-tab&runId=32685148&resultId=110461&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

It looks like it does over 4,000,000 loop iterations. Is this necessary? Can it do fewer and still be as effective a test?
@BruceForstall BruceForstall added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs labels Apr 1, 2021
@BruceForstall BruceForstall added this to the 6.0.0 milestone Apr 1, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 1, 2021
BruceForstall added a commit to BruceForstall/runtime that referenced this issue Apr 1, 2021
@BruceForstall
Disable Comparer_get_Default under GCStress
2fc2ee7 
It fails with timeout under GCStress=3.

Tracking: dotnet#50594
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Apr 1, 2021
@BruceForstall BruceForstall mentioned this issue Apr 1, 2021
Closed
@runfoapp runfoapp bot mentioned this issue Apr 1, 2021
Closed
@EgorBo EgorBo mentioned this issue Apr 1, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 2, 2021
@SingleAccretion SingleAccretion mentioned this issue Apr 6, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Simplify Comparer_get_Default runtime test EgorBo/runtime-1
2 participants
@EgorBo @BruceForstall