Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore composite images in Crossgen2 inputs #49247

Closed
trylek opened this issue Mar 5, 2021 · 1 comment · Fixed by #62537
Closed

Ignore composite images in Crossgen2 inputs #49247

trylek opened this issue Mar 5, 2021 · 1 comment · Fixed by #62537
Labels
area-crossgen2-coreclr
Milestone
7.0.0

Comments

@trylek
Copy link
Member

trylek commented Mar 5, 2021

When Crossgen2 is asked to compile a folder that's already been compiled with Crossgen2 in composite mode, the compilation fails because the compiler finds the composite DLL and claims it uses unsupported managed C++. Crossgen2 should be able to recognize previously produced composite files and just skip them as inputs similar to what it does for native DLLs.

/cc @dotnet/crossgen-contrib
@trylek trylek added this to the 6.0.0 milestone Mar 5, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 5, 2021
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Mar 5, 2021
@mangod9
Copy link
Member

mangod9 commented Jul 26, 2021

assume there is a workaround for this, so moving to 7

@mangod9 mangod9 modified the milestones: 6.0.0, 7.0.0 Jul 26, 2021
@trylek trylek mentioned this issue Dec 9, 2021
Merged
trylek added a commit to trylek/runtime that referenced this issue Dec 9, 2021
@trylek
Skip native composite ReadyToRun images as inputs to Crossgen2
17b8ad1 
According to the issue dotnet#49247
a known pre-existing Crossgen2 bug is that it fails when presented
with the components of a previous Crossgen2 compilation in the
composite mode. This is because Crossgen2 lacks proper logic to
recognize the composite images and mistakes them for currently
unsupported managed C++ MSIL assemblies. This change adds the extra
check; I have also unified it between Crossgen2 and R2RDump.

Thanks

Tomas
trylek added a commit that referenced this issue Dec 11, 2021
@trylek
Skip native composite ReadyToRun images as inputs to Crossgen2 (#62537)
4fb7f77 
According to the issue #49247
a known pre-existing Crossgen2 bug is that it fails when presented
with the components of a previous Crossgen2 compilation in the
composite mode. This is because Crossgen2 lacks proper logic to
recognize the composite images and mistakes them for currently
unsupported managed C++ MSIL assemblies. This change adds the extra
check; I have also unified it between Crossgen2 and R2RDump.

Thanks

Tomas
@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Skip native composite ReadyToRun images as inputs to Crossgen2 trylek/runtime
2 participants
@trylek @mangod9